Comments (2)
Current status: fix for clippy errors/warnings is ongoing. After changes be70aa3, 91ae5fc, cb32344, 0b6e2ec, f90ab06, and c9c5df8 are applied, as of now, rest of warnings are below:
$ cargo clippy 2>&1 | egrep "^warning:|^error:" | sort | uniq -c | sort -nr
13 warning: redundant field names in struct initialization
13 warning: length comparison to zero
9 warning: writing `&String` instead of `&str` involves a new object where a slice will do.
7 warning: redundant clone
6 warning: Constants have by default a `'static` lifetime
4 warning: identical conversion
3 warning: unneeded unit expression
3 warning: this import is redundant
3 warning: called `.as_ref().map(Deref::deref)` (or with one of deref aliases) on an Option value. This can be done more directly by calling `cx.output.as_deref()` instead
2 warning: use of `unwrap_or` followed by a function call
2 warning: use of `expect` followed by a function call
2 warning: taken reference of right operand
2 warning: struct update has no effect, all the fields in the struct have already been specified
2 warning: single-character string constant used as pattern
2 warning: calling `to_string` on `&&str`
1 warning: using `clone` on a `Copy` type
1 warning: useless use of `format!`
1 warning: unneeded `()`
1 warning: this is an `else if` but the formatting might hide it
1 warning: this boolean expression can be simplified
1 warning: the variable `key_id` is used as a loop counter.
1 warning: the variable `i` is used as a loop counter.
1 warning: redundant closure found
1 warning: called `.as_ref().map(Deref::deref)` (or with one of deref aliases) on an Option value. This can be done more directly by calling `s.as_deref()` instead
1 warning: called `.as_ref().map(Deref::deref)` (or with one of deref aliases) on an Option value. This can be done more directly by calling `cx.clone().output.as_deref()` instead
1 warning: You checked before that `unwrap()` cannot fail. Instead of checking and unwrapping, it's better to use `if let` or `match`.
1 warning: You are using an explicit closure for cloning elements
More commits will be added into #7 to fix warnings above.
from dynein.
Now #7 has been merged and GitHub workflow passed https://github.com/awslabs/dynein/actions/runs/375814880. Resolving the issue.
$ cargo clippy
Finished dev [unoptimized + debuginfo] target(s) in 0.08s
from dynein.
Related Issues (20)
- Implement IaC feature enpowered by CloudFormation HOT 4
- [test] Improve setup function
- `cargo test` failed due to difference in command output on windows environment HOT 1
- Implement sophisticated parser for put command HOT 1
- Implement sophisticated parser for query command
- Implement sophisticated parser for bwrite command HOT 1
- `bwrite` command does not support binary data types HOT 1
- `desc_all_tables` integration test sometimes fails HOT 1
- Race condition of loading config cause EndOfStream HOT 1
- Allow Full Attributes on Query or Scan HOT 5
- Dynein format does not accept valid JSON string HOT 1
- Add format option to show dynein format
- Inference preferable format based on the situation
- Support DynamoDB JSON for import/export table HOT 3
- Add base64 literal for binary type to dynein format HOT 1
- Specify target OS for creating binaries
- Create a option like `EXPLAIN` of SQL to check actual JSON parameter
- Support retry when batch write items HOT 1
- Change tests to use separate configurations for `cargo test` HOT 1
- `dy admin create table` should update the table cache
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dynein.