Comments (7)
One design choice I made here in the spirit of "reasonable defaults" was to use the default VPC rather than spinning up an entirely separate VPC or asking the user to provide a VPC ID to not litter a user's account and to prevent option sprawl respectively. My thought was that a user encountering this error could just re-create their default VPC (via http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/default-vpc.html#create-default-vpc).
It'd be nice to help the user out here though. It seems like this could be tackled a number of different ways. If the default VPC isn't available, we could do one or more of the following options:
- Return an error and ask the user to provide a VPC ID when creating new services and load balancers and running new tasks
- Create a new VPC and n subnets (where n = the number of availability zones the account can access)
- Create a new default VPC (which is a single API call)
- Continue to blow up, but return a more useful error message explaining how to create a default VPC
I'm learning toward returning a more useful error message as a user might have had good reason not to want a default VPC.
Any thoughts/opinions? Thanks so much for opening this.
from fargatecli.
I would think, it would be best to provide a VPC ID and Cluster Name on the command line. As we have several Clusters and VPCs that we use to separate out services.
from fargatecli.
@lecole Thanks. I think I'm sold on adding cluster as a command line option for task
and service
commands.
I'm still not sure on the above VPC question though. Asking the user to provide a VPC ID seems to introduce mental overhead and could potentially create issues. i.e., I create a load balancer in one VPC, and try to use it in another. Now there's another new magic string I need to correlate. I suppose we could default to the default VPC, and just allow it to be overridden (a la option 1 above).
from fargatecli.
@jpignata Sounds like a good plan. But what if you also added the VPC as an option and then also implemented option 1. This would give some control over which VPC you want it to go into (without the error), and also as a default have the "default VPC" as the target deployment location.
from fargatecli.
@lecole Thanks for the input! I'll tinker with this over the next day or two and try to get a 0.2.0 release together with something to address these two pain points.
from fargatecli.
Sounds good. Great work so far.
from fargatecli.
Released v0.2.0 to address the above.
from fargatecli.
Related Issues (20)
- Link to CircleCi build is broken HOT 1
- Question: Support for running multiple containers within a single task? HOT 4
- Create lb with http and https HOT 1
- On going project development & support HOT 5
- ECS Fargate support for EFS HOT 2
- Ability to stop service task by id
- fargatecli to support the China region HOT 1
- Circle CI tag at master readme does not render
- fargate service list is not show the result when it has more 20 services.
- Fargate cli not working
- Fargate CLI versus Copilot CLI? HOT 2
- Allow passing arguments to docker HOT 1
- Env variables cannot contain comma in the value HOT 1
- version 0.3.1 returning v0.3.0 with --version HOT 3
- `fargate service env set` triggers a deploy HOT 1
- service deploy deletes secrets array values
- default region cannot be changed HOT 1
- Create new release automation
- Create new documentation page HOT 1
- New install instructions needed HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fargatecli.