Giter VIP home page Giter VIP logo

Comments (5)

wmesard avatar wmesard commented on August 11, 2024 2

Agree about rm --all. Users should probably have to work a little harder to shoot themselves in the foot. I would be in favor of adding a -q option to soci index list though (following the precedent set by nerdctl). Then users could say

soci index rm $(soci index list -q )

And soci index rm --ref <image-digest> would be nice.

from soci-snapshotter.

wmesard avatar wmesard commented on August 11, 2024 1

This was pointed at "3" after the following discussion:

This issue is just to delete the SOCI index manifest, but not delete the zTOCs. TBD whether zTOCs need to be cleaned up by hand (which would require a soci ztoc rm, as described above), or whether we would get all fancy and implement garbage collection of orphaned zTOCs.

A one-pager is probably needed to describe what we want the holistic artifact management experience to be, and then see what stories fall out of that.

But the immediate pain point is that if you create a second SOCI index for an image, but want soci push to upload the first one, you can't today.

from soci-snapshotter.

wmesard avatar wmesard commented on August 11, 2024

Request for clarification: Would this command also delete the zTOCs blobs contained in the index? What if the zTOCs are part of multiple SOCI indices (e.g., if it's from a base index layer used by multiple container images)? To do this right, we'd either have to sign up for reference counting, or periodic garbage collection sweeps.

Maybe that's the right thing to do. But maybe we should wait until we can use the containerd store to store the SOCI artifacts, rather than reinvent that wheel.

from soci-snapshotter.

rdpsin avatar rdpsin commented on August 11, 2024

My initial thought was that only index blobs would be deleted + entry deleted from the db. Ztoc deletion should be part of soci ztoc rm command. That does raise the question of what happens to indexes if ztocs are deleted. I don't have the answer to that.

from soci-snapshotter.

torredil avatar torredil commented on August 11, 2024

3

from soci-snapshotter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.