Giter VIP home page Giter VIP logo

Comments (29)

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024 1

It looks nice to me just decrease the height it must not take the full height of the sreen

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

@Agarwalvidu @ayush-that please check

from finveda.

deepeshmlgupta avatar deepeshmlgupta commented on August 30, 2024

@VijaySamant4368 can please share your sample design

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

Go ahead!

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

@Agarwalvidu @deepeshmlgupta how does this look?
https://github.com/user-attachments/assets/03bb0478-9b9e-4418-81ff-9f5d87f950e9

I have yet to do some minor details, but this is the main part.
I would like to know your opinion before going forward.

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024
Screen.Recording.2024-07-23.005142.mp4

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

@Agarwalvidu @deepeshmlgupta should I change the design? Or should I proceed with this?

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

How it will look like in mobile view?

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

And only with icons one will get confused what page is about what.

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

@Agarwalvidu To be honest, I had different ideas for showing only Emojis in as the links. My idea for nav-bar with full links display are limited. Here is a general one:

Screen.Recording.2024-07-25.224546.mp4

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

I think this is same as previous one🥲

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

Try this one
https://codepen.io/zakandaiev/pen/RwwBvrJ

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

I think this is same as previous one🥲
Oh I just noticed it. I am really sorry for the disappointment, I am currently just out of ideas.

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

Try this one https://codepen.io/zakandaiev/pen/RwwBvrJ

On it.

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

@Agarwalvidu please have a look at this:

Screen.Recording.2024-07-25.231218.mp4

The colors and the items in the nav-bar can be changed without much hassle.

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

This looks nice to me. Please go ahead with this one. One suggestion you can add a box around the nav items and make it more creative

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

All right, I will!!!

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

@Agarwalvidu I think that adding a box around the nav-items inside the hamburger-menu, will make it feel very much different than the original menu.
I have this in my mind:

Screen.Recording.2024-07-26.092039.mp4

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

It gives a similar feel as the original nav-bar.

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

@Agarwalvidu these are the screenshots for different height:

70%:
Screenshot 2024-07-26 at 09-58-42 Home - FinVeda

90%:
Screenshot 2024-07-26 at 09-59-14 Home - FinVeda

100%:
Screenshot 2024-07-26 at 10-00-40 Home - FinVeda

I believe it is better looking at 100%, can you please provide your opinion?
Thanks.

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

I took screenshot for comparatively wider width for better visualization.

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

Yes 100% one is looking good!
Finally raise the PR.

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

Make sure it will not cover the whole width, as it is looking good in this width!

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

For less wider screen:
70%:
Screenshot 2024-07-26 at 10-08-13 Home - FinVeda

90%:
Screenshot 2024-07-26 at 10-07-32 Home - FinVeda

100%:
Screenshot 2024-07-26 at 10-02-50 Home - FinVeda

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

Make sure it will not cover the whole width, as it is looking good in this width!

Al right!

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

Whichever suits you best, I am liking the 70% most!

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

Ok, I will make it 70% then.

from finveda.

VijaySamant4368 avatar VijaySamant4368 commented on August 30, 2024

I am sorry but there seems to be a problem for height of 70%. For screens with less width, 70% will be quite compact, and a lot of things would have to be adjusted. SO I think we should avoid unnecessary extra fragility to the responsive nature.

from finveda.

Agarwalvidu avatar Agarwalvidu commented on August 30, 2024

Okay!

from finveda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.