Giter VIP home page Giter VIP logo

Comments (2)

lewfish avatar lewfish commented on September 20, 2024 1

@AdeelH The second option seems more intuitive to me, and I would prefer that.

from raster-vision.

AdeelH avatar AdeelH commented on September 20, 2024

@lewfish, which of the following do you think looks more intuitive? Currently, RV is doing a mix of both which is buggy.

Option 1

Pixel indices correspond to the pixel indices in the source file. So, e.g., the first chip_sz=5 window will have a different address depending on the crop. This is simpler and closer to how RV used to handle this in earlier versions.

rs = RasterioSource(..., extent=Box(10, 10, 20, 20))
rs.extent # Box(10, 10, 20, 20)

rs.get_chip(Box(0, 0, 5, 5)) # outside the extent so blank chip
rs.get_chip(Box(10, 10, 15, 15)) # correct window to get the first chip (chip_sz=5)

rs[:5, :5] # equivalent to rs.get_chip(Box(0, 0, 5, 5)), blank chip
rs[10:15, 10:15] # equivalent to rs.get_chip(Box(10, 10, 15, 15)), first legit chip

Option 2

Here, pixel indices are relative to the crop. So the first chip_sz=5 window will always be Box(0, 0, 5, 5) regardless of the crop, which is arguably more user-friendly.

rs = RasterioSource(..., bbox=Box(10, 10, 20, 20))
rs.extent # Box(0, 0, 10, 10), always == (0, 0, H, W)
rs.bbox # Box(10, 10, 20, 20)

rs.get_chip(Box(0, 0, 5, 5)) # correct window to get the first chip (chip_sz=5)
rs.get_chip(Box(10, 10, 15, 15)) # outside the extent so blank chip

rs[:5, :5] # equivalent to rs.get_chip(Box(0, 0, 5, 5)), first legit chip
rs[10:15, 10:15] # equivalent to rs.get_chip(Box(10, 10, 15, 15)), blank chip

from raster-vision.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.