Giter VIP home page Giter VIP logo

Comments (7)

Blipz avatar Blipz commented on August 24, 2024 2

I tried implementing a potenty bordure once (using SVG masks and stroke-dasharray) and the results were not great, especially in the corners. My conclusion was that this would need defining a different path for each shield shape and for each variation (so way too much work).

from armoria.

Azgaar avatar Azgaar commented on August 24, 2024

These are just technical limitations

from armoria.

ChevronTango avatar ChevronTango commented on August 24, 2024

Does that preclude the chevrons and other ordinaries from having those aswell?

I'd also add, is it worth cotising being a separate parameter? Those can be a different tincture to the ordinary itself, and can often be a different varient too (eg. An embattled chevron, with normal cotise, and vice versa).

from armoria.

Azgaar avatar Azgaar commented on August 24, 2024

It does not, but it's hard to do and require a lot of time to implement. It's an open source project, so you can implement this feature on your own and make it available for others.

from armoria.

Blipz avatar Blipz commented on August 24, 2024

Here is an example of issues with bordure when trying to do it the "simple way":

Similarly, this might look weird for chevrons at the angle points. For anyone wanting to try it, the following can be done:

  • Define chevron as a lined ordinary instead of straight in dataModel.js
  • Add a new chevronLined entry in the templates object of templates.js, that should be similar to the chevron entry but with additional fancy lines with proper rotation and translation (look at other lined ordinaries to see how it is done)

from armoria.

ChevronTango avatar ChevronTango commented on August 24, 2024

I actually don't think that looks too bad. Granted, it's not perfect, but I've honestly seen real rendering that look far worse than this.

I've not looked at the code, so don't know how the rendering on each edge works, but you might be able to make a few simple tweaks, like offsets to the pattern and the start and end , or the scale on eaxh edge so they arent uniform, to tidy it up a bit. Honestly I think that looks fine though, especially considering we don't have any options right now to do it.

Similarly, this might look weird for chevrons at the angle points. For anyone wanting to try it, the following can be done:

I might give it a play when I get a free moment. Could be fun.

from armoria.

Azgaar avatar Azgaar commented on August 24, 2024

simple tweaks

These simple tweaks and not simple at all

from armoria.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.