Comments (12)
If I am not wrong, #43 this solves the issue, right?
from aci-deploy.
A year later this is still not fixed(released)?
from aci-deploy.
Sure, will do. I put it here because I felt like it was a bit of a regression from the fix.
from aci-deploy.
I'm having this issue as well.
from aci-deploy.
I think this will always throw an error if ipAddress != 'Public'
aci-deploy/src/taskparameters.ts
Line 71 in 5eddcda
I think something like if(!(ipAddress == "Public" || ipAddress == "Private"))
would work. I'm not exactly sure how to contribute here. This seems to be the same pattern for the other params that have either options like @crbaker mentioned above.
When I try to use my fork as the action I got a Failed to fetch Azure access token
error.
from aci-deploy.
Underlying bug also causes #17.
Looks like whomever wrote the initial code thought that a != b && c
evaluated like ![b, c].includes(a)
instead of as it really does (a != b) && (true)
...
from aci-deploy.
This issue is marked need-to-triage for generating issues report.
from aci-deploy.
@daliborsavanovic @crbaker @jakep36
This has been fixed in the patch version. We'll soon update the major version as well.
Can you please verify if using [email protected] solves the issue and works well?
from aci-deploy.
Hi @kanika1894,
Haven't tried new version, but I can see a flaw there also, you're missing network profile parameter..
I have fixed my own (forked) version of this and continued..
from aci-deploy.
Hey @daliborsavanovic , can you please more context around the network profile parameter?
The intention behind having v1.1.1 was to fix #17 and #3.
But as per my understanding, there is something else that needs to be included?
Thank you for your inputs :)
from aci-deploy.
Looks like this is still broken because there is a dependency on dns-name-label that can't be met if you want private ip.
aci-deploy/src/taskparameters.ts
Line 48 in abb2c5f
from aci-deploy.
@chelnak can you please create a separate issue for this?
This seems like making a parameter optional based on a condition, which we can handle separately.
The fix for the conditions is rolled out using #43
from aci-deploy.
Related Issues (20)
- Multi Container Groups HOT 9
- Setting `ip-address` to `Private` causes an error HOT 12
- Container group cannot be updated HOT 9
- secure-environment-variables have visible values in azure portal HOT 11
- Multiple azure-file-volume-share-name and azure-file-volume-mount-path pairs support HOT 3
- Add support for using a configuration file HOT 5
- Make it easier to understand when it takes time to deploy an image HOT 3
- Feature request: In the documentation be more clear that you can/should set CPU/RAM HOT 1
- Start, Stop and Restart container instances HOT 2
- Prophet Model Deployment ERROR HOT 3
- Container App: CI deploy from GitHub failing after transferring ownership HOT 2
- Removing JS from version control HOT 6
- This issue is marked need-to-triage for generating issues report. HOT 2
- Add support for Vnet integration HOT 6
- Upgrade to node16 + stop using the "set-output" command HOT 3
- Azure ACI doesn't restart when log-analytics-workspace-* key/values are set
- How to deal with docker-compose projects?
- Error: Encountered an internal server error. The tracking activity id is '...', correlation id is '...' HOT 3
- Include guidance on .NET 8 deployment
- GitHub Actions Fails to Recognize Successful Azure Container Instances Deployment
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aci-deploy.