uws_client: No indication that WebSocket has been closed, if close is initiated by server. about azure-c-shared-utility HOT 2 OPEN

HI @minichma,

After uws_client sends the CLOSE frame response
https://github.com/Azure/azure-c-shared-utility/blob/master/src/uws_client.c#L1554
It does close the underlying I/O right after:
https://github.com/Azure/azure-c-shared-utility/blob/master/src/uws_client.c#L1561
Before invoking on_ws_peer_closed
https://github.com/Azure/azure-c-shared-utility/blob/master/src/uws_client.c#L1573

So if you receive a on_ws_peer_closed, you can stop calling dowork right away and destroy the client.

from azure-c-shared-utility.

Hi @ewertons,

Thanks for the clarification and sorry for the late reply. Maybe I'm understanding this wrong, but to my understanding the underlying xio could be implemented in an asynchronous manner. Therefore after calling the close function, the underlying layers might still be busy. After uws_client reports it's ready, I would expect that I can just tear down the underlying stack, but this doesn't seem to be the case. Instead I have to ask the underlying layer whether it's still busy and tear it down only when its finished. So I would expect uws_client to signal that closing is complete only after closing of the underlying TLS/TCP connection has completed as well. To my understanding this is how uws_client_close_async handles the closing procedure.

Does this make sense?

from azure-c-shared-utility.