Comments (6)
This change has already been made, but is not released yet: #1749
We intend to make further changes before releasing.
from azure-functions-dotnet-worker.
Has this fix been release yet?
from azure-functions-dotnet-worker.
Not to nuget.org yet, but a build is available here for testing:
https://dev.azure.com/azfunc/Azure%20Functions/_artifacts/feed/AzureFunctionsTempStaging/NuGet/Microsoft.Azure.Functions.Worker.Sdk/overview/1.16.0-preview2
from azure-functions-dotnet-worker.
There may be further issues here, in that Directory.Build.props and Directory.Build.targets can also affect the resultant sources.
Your PR referenced above explicitly blocks this.
We use the RestoreAdditionalProjectSources element to conditionally add more sources.
If the goal is to avoid extra code assets from being included, maybe consider adding build properties that can be evaluated in our props and targets to avoid bringing in code assets. As long as this is well documented we can control this.
from azure-functions-dotnet-worker.
@slaneyrw not including directory.build.targets is intentional as we want to tightly control the properties and values of this generated project. Allowing these additional targets to implicitly flow in will make our inner build too susceptible to accidental breaks due to those targets/props. This will be a headache for customers as changing TFM, output directory, etc can lead to breaks that will be very hard to understand.
The refactored targets do pass in the parents nuget restore sources explicitly to the inner build, I'll verify if this includes RestoreAdditionalProjectSources
from azure-functions-dotnet-worker.
@slaneyrw I believe the SDK changes in PR right now will include RestoreAdditionalProjectSources
, I am passing $(_OutputSources)
to the inner-build, which is what the nuget targets calculate as the combination of all input nuget restore sources for the current project.
from azure-functions-dotnet-worker.
Related Issues (20)
- Serverless signalR: Adding a user to a group and sending a message to the group simultaneously in upstream HOT 3
- Evaluate test coverage
- The target framework 'net8.0' must be 'net6.0'. Verify if target framework has been overridden by a global property. HOT 41
- .NET 8 Isolated Function - RpcExceptions and rogue "ProblemId" logs HOT 2
- How to read function parameter values from FunctionContext for middleware
- 'Stream' input/output support for azure Blob functions seems broken HOT 3
- TableInput for single entity returns array with all entities in that partition HOT 2
- [Docs] Add docs for new HTTP output binding HOT 2
- Middleware is not consistently writing the response when using ASP.Net Core Integration HOT 8
- Similar issue I am facing while upgrading to dotnetframework8 and using isolated function HOT 2
- Allow Middleware to alter Functions output for ServiceBus Message Binding HOT 3
- Add task in pipeline to deploy new throughput apps
- Throughput Testing Cleanup HOT 1
- Throughput Test Alerting
- BindInputAsync caches without regard to type, which leads to invalid cast later HOT 4
- SignalR extensions 1.13.0 Could not load file or assembly 'Microsoft.Extensions.Options, Version=7.0.0.0, HOT 2
- Enhancing Configuration Flexibility for Azure Functions Triggers
- .Net8 Isolated worker Service Bus Trigger "No Job functions found" error when deploying code to azure functions HOT 19
- Inject class-based SignalR ServerlessHub to other Azure Function classes HOT 2
- Function.deps.json references .NET 6 instead of .NET 8, causing security vulnerabilities to be flagged HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-functions-dotnet-worker.