Giter VIP home page Giter VIP logo

Comments (6)

jviau avatar jviau commented on July 21, 2024

This change has already been made, but is not released yet: #1749

We intend to make further changes before releasing.

from azure-functions-dotnet-worker.

kemmis avatar kemmis commented on July 21, 2024

Has this fix been release yet?

from azure-functions-dotnet-worker.

jviau avatar jviau commented on July 21, 2024

Not to nuget.org yet, but a build is available here for testing:
https://dev.azure.com/azfunc/Azure%20Functions/_artifacts/feed/AzureFunctionsTempStaging/NuGet/Microsoft.Azure.Functions.Worker.Sdk/overview/1.16.0-preview2

from azure-functions-dotnet-worker.

slaneyrw avatar slaneyrw commented on July 21, 2024

There may be further issues here, in that Directory.Build.props and Directory.Build.targets can also affect the resultant sources.
Your PR referenced above explicitly blocks this.

We use the RestoreAdditionalProjectSources element to conditionally add more sources.

If the goal is to avoid extra code assets from being included, maybe consider adding build properties that can be evaluated in our props and targets to avoid bringing in code assets. As long as this is well documented we can control this.

from azure-functions-dotnet-worker.

jviau avatar jviau commented on July 21, 2024

@slaneyrw not including directory.build.targets is intentional as we want to tightly control the properties and values of this generated project. Allowing these additional targets to implicitly flow in will make our inner build too susceptible to accidental breaks due to those targets/props. This will be a headache for customers as changing TFM, output directory, etc can lead to breaks that will be very hard to understand.

The refactored targets do pass in the parents nuget restore sources explicitly to the inner build, I'll verify if this includes RestoreAdditionalProjectSources

from azure-functions-dotnet-worker.

jviau avatar jviau commented on July 21, 2024

@slaneyrw I believe the SDK changes in PR right now will include RestoreAdditionalProjectSources, I am passing $(_OutputSources) to the inner-build, which is what the nuget targets calculate as the combination of all input nuget restore sources for the current project.

from azure-functions-dotnet-worker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.