Giter VIP home page Giter VIP logo

Comments (5)

ryancrawcour avatar ryancrawcour commented on July 3, 2024 2

I'd say let's pick one. Then if customers ask for the other one, or complain about the one we picked, we can then always come back and revisit this.

I am happy with "you're expected to ensure your consumer is idempotent b/c at-least-once semantics" and go for the higher throughput.

from azure-functions-kafka-extension.

jeffhollan avatar jeffhollan commented on July 3, 2024

I imagine the risk of StoreOffset is that if something happens on the async thread and the commit doesn't checkpoint you may end up in a world where you replay a few batches of messages you thought were being checkpoint but the checkpoint was never active? In general we are pretty clear you need to be at-least-once expected, so I think I'm ok with the StoreOffset given the better throughput.

The other alternative is we make it a configurable choice in the host.json config so they can choose the method they want and we default to one.

from azure-functions-kafka-extension.

ryancrawcour avatar ryancrawcour commented on July 3, 2024

ou need to be at-least-once expected, so I think I'm ok with the StoreOffset given the better throughput.

that's my feeling too

from azure-functions-kafka-extension.

ryancrawcour avatar ryancrawcour commented on July 3, 2024

we make it a configurable choice

that's not a bad idea. how complex would this make the code @fbeltrao ?

from azure-functions-kafka-extension.

fbeltrao avatar fbeltrao commented on July 3, 2024

The code to support both is not complex. I am questioning the value.

What Jeff says is right, consumers should be implemented to process messages at least once anyway.

I can run a few tests to see if the messages processing repetition is noticeable in our e2e tests if we optimize for throughput.

from azure-functions-kafka-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.