GetRegistrationsBy* returns Gcm*Registration instead of Fcm about azure-notificationhubs-dotnet HOT 6 CLOSED

You're correct in that the SDK should fully switch to Fcm types and indeed there was a conversion missing in one of the internal methods, resulting in obsolete Gcm types being occasionally returned.

Thanks for reporting this, we hope to get a fix rolled out soon! 🙂

from azure-notificationhubs-dotnet.

@alex-zyl Fixed in version 3.0.1.

from azure-notificationhubs-dotnet.

@igprya
This is great! Thanks!

from azure-notificationhubs-dotnet.

@igprya @stankovski
Guys, do I need permissions to create new branch and open a PR? Was trying to push into remote branch, but got 403

from azure-notificationhubs-dotnet.

@alex-zyl Yes, only the owners of the repository are able to alter branches. In order to introduce a change you first need to fork the repository and implement desired changes in a new branch inside your own fork.

When your feature is ready, you'll have an option to create a pull request that will propose to merge a branch with a feature from your fork into the master branch of this repository.

For example, the pull request that fixed the bug you've reported (#25) actually merged a fcm-support-readentities-fix branch from my fork into this repository's master branch.

Hope that helps!

from azure-notificationhubs-dotnet.

@igprya
Thanks for the hint. PR created

from azure-notificationhubs-dotnet.