The method borrows account and <code class="notransla

client::with_bearer_token() borrows account and token parameters about azure-sdk-for-rust HOT 5 CLOSED

spektom commented on August 20, 2024

client::with_bearer_token() borrows account and token parameters

from azure-sdk-for-rust.

Comments (5)

rylev commented on August 20, 2024

Yes, I don't think there's any reason to not take ownership of account and token.

from azure-sdk-for-rust.

MindFlavor commented on August 20, 2024

Hi spektom,
client::with_bearer_token() allows borrowing and taking ownership while both client::with_access_key and client::with_azure_sas only allow borrowing. See:

azure-sdk-for-rust/sdk/storage/src/core/client.rs

Line 155 in c4455a2

pub fn with_access_key(account: &str, key: &str) -> KeyClient {

and

azure-sdk-for-rust/sdk/storage/src/core/client.rs

Line 139 in c4455a2

pub fn with_azure_sas(account: &str, sas_token: &str) -> KeyClient {

While client::with_bearer_token() allows both borrowing and taking ownership.

azure-sdk-for-rust/sdk/storage/src/core/client.rs

Lines 229 to 232 in c4455a2

 pub fn with_bearer_token<'a, A, BT>(account: A, bearer_token: BT) -> BearerTokenClient<'a> 

 where 

 A: Into<Cow<'a, str>>, 

 BT: Into<Cow<'a, str>>,

So they should behave just the same (with client::with_bearer_token() being more flexible).

For example, this borrows:

azure-sdk-for-rust/sdk/storage/examples/blob_00.rs

Lines 17 to 24 in c4455a2

 let container = std::env::args() 

 .nth(1) 

 .expect("please specify container name as command line parameter"); 

 let blob = std::env::args() 

 .nth(2) 

 .expect("please specify blob name as command line parameter"); 

 let client = client::with_access_key(&account, &master_key);

This example takes ownership:

azure-sdk-for-rust/sdk/storage/examples/blob_02_bearer_token.rs

Lines 13 to 26 in c4455a2

 let account = std::env::args() 

 .nth(1) 

 .expect("please specify the account name as first command line parameter"); 

 let container = std::env::args() 

 .nth(2) 

 .expect("please specify the container name as second command line parameter"); 

 let blob = std::env::args() 

 .nth(3) 

 .expect("please specify the blob name as third command line parameter"); 

 let bearer_token = std::env::args() 

 .nth(4) 

 .expect("please specify the bearer token as fourth command line parameter"); 

 let client = client::with_bearer_token(account, bearer_token);

But the latter works just the same if you borrow instead:

    let client = client::with_bearer_token(&account, &bearer_token);

Can you please provide a repro of your problem?

from azure-sdk-for-rust.

spektom commented on August 20, 2024

Thanks, and sorry for bothering.

from azure-sdk-for-rust.

MindFlavor commented on August 20, 2024

Thanks, and sorry for bothering.

Don't worry, you correctly pointed out that we have uneven builders: the all should allow both borrowing and owning 👍 !

from azure-sdk-for-rust.

rylev commented on August 20, 2024

I somewhat disagree. I don't think allowing for the flexibility of taking either a reference or an owned value is really worth the complexity. Taking these as String instead of Cow<'a, str> would simplify the API considerably at only a very minimal potential runtime cost.

from azure-sdk-for-rust.

client::with_bearer_token() borrows account and token parameters about azure-sdk-for-rust HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	pub fn with_bearer_token<'a, A, BT>(account: A, bearer_token: BT) -> BearerTokenClient<'a>
	where
	A: Into<Cow<'a, str>>,
	BT: Into<Cow<'a, str>>,

	let container = std::env::args()
	.nth(1)
	.expect("please specify container name as command line parameter");
	let blob = std::env::args()
	.nth(2)
	.expect("please specify blob name as command line parameter");

	let client = client::with_access_key(&account, &master_key);

	let account = std::env::args()
	.nth(1)
	.expect("please specify the account name as first command line parameter");
	let container = std::env::args()
	.nth(2)
	.expect("please specify the container name as second command line parameter");
	let blob = std::env::args()
	.nth(3)
	.expect("please specify the blob name as third command line parameter");
	let bearer_token = std::env::args()
	.nth(4)
	.expect("please specify the bearer token as fourth command line parameter");

	let client = client::with_bearer_token(account, bearer_token);