Comments (7)
anwather
commented on September 7, 2024
1
Just fork the repo, create a branch on the fork, make changes and create a pull request please.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: ahsulli ***@***.***>
Sent: Friday, July 12, 2024 2:24:41 AM
To: Azure/enterprise-azure-policy-as-code ***@***.***>
Cc: Mention ***@***.***>; Comment ***@***.***>; Assign ***@***.***>; State change ***@***.***>; Subscribed ***@***.***>
Subject: Re: [Azure/enterprise-azure-policy-as-code] Get Existing AzureChinaCloud Exemptions not Returning Non-Management Group Scoped Exemptions (Issue #691)
@anwather<https://github.com/anwather>, can someone please grant me access to create a branch and PR? I have the code already prepared on my local. The code has been successfully tested numerous times against my organization's China and Commercial tenants. Hopefully that helps too.
—
Reply to this email directly, view it on GitHub<#691 (comment)> or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWCJVQGKYJNQZHP25XC2DTZL2WUTBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDOMRVHE4DSNBXHCSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRSG4ZDKOJYHE2DQMVENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTGMZXGE3DEOBTHCBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIZTOMZXGA2DONJUQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSG4ZDKOJYHE2DOOECUR2HS4DFUVWGCYTFNSSXMYLMOVS2UMRXGI2TSOBZGQ4DFJ3UOJUWOZ3FOKTGG4TFMF2GK>.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
from enterprise-azure-policy-as-code.
ahsulli
commented on September 7, 2024
1
@anwather, I have created PR: #702
from enterprise-azure-policy-as-code.
anwather
commented on September 7, 2024
Closing as issue is defined in #692
from enterprise-azure-policy-as-code.
ahsulli
commented on September 7, 2024
@anwather, just to further clarify, you can also reproduce this issue by running Build-DeploymentPlans as well. However, this version of the repro steps produces an erroneous output that is less obvious to see but is still flawed for the same reason.
from enterprise-azure-policy-as-code.
ahsulli
commented on September 7, 2024
@anwather, issue is still present. Please fix. Cannot run deployment plans against China tenants as a result.
from enterprise-azure-policy-as-code.
anwather
commented on September 7, 2024
OK you mentioned you had code to fix this can you please submit a PR. I don't have access to a China tenant to run this against.
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: ahsulli ***@***.***>
Sent: Wednesday, July 10, 2024 4:29:59 AM
To: Azure/enterprise-azure-policy-as-code ***@***.***>
Cc: Mention ***@***.***>; Comment ***@***.***>; Assign ***@***.***>; State change ***@***.***>; Subscribed ***@***.***>
Subject: Re: [Azure/enterprise-azure-policy-as-code] Get Existing AzureChinaCloud Exemptions not Returning Non-Management Group Scoped Exemptions (Issue #691)
@anwather<https://github.com/anwather>, issue is still present. Please fix. Cannot run deployment plans against China tenants as a result.
—
Reply to this email directly, view it on GitHub<#691 (comment)> or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACWCJVTCXOIN6EEU5MCZFW3ZLQT2RBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDOMRVHE4DSNBXHCSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRSG4ZDKOJYHE2DQMVENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTGMZXGE3DEOBTHCBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIZTOMZXGA2DONJUQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSG4ZDKOJYHE2DOOECUR2HS4DFUVWGCYTFNSSXMYLMOVS2UMRXGI2TSOBZGQ4DFJ3UOJUWOZ3FOKTGG4TFMF2GK>.
You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
from enterprise-azure-policy-as-code.
ahsulli
commented on September 7, 2024
@anwather, can someone please grant me access to create a branch and PR? I have the code already prepared on my local. The code has been successfully tested numerous times against my organization's China and Commercial tenants. Hopefully that helps too.
from enterprise-azure-policy-as-code.
Related Issues (20)
- Fix user assigned managed identity export HOT 2
- Export-AzPolicyResources Failing for AzureChinaCloud Tenants HOT 3
- Handle role assignments when managed identity is a member of a group HOT 1
- EPAC Plan Taking 15min to run HOT 1
- Duplicate exemption Id HOT 6
- Error building exemptions with Build-DeploymentPlans HOT 4
- Document All Assignments Option
- Failed exemption deployments do not throw errors HOT 3
- "Deprecated" in policy description for Custom policies will Disable the policy HOT 2
- [Enable Azure Monitor for VMs & VMss] Role assignment when using your own User Assigned Identity located in the caf "management" Management Group HOT 1
- Policy Set with single parameter used across multiple definitions causes error in Build-DeploymentPlans HOT 1
- ADO pipeline is constantly resulting with write-error "Assignment JSON file './Definitions/global-settings.jsonc' is not valid." HOT 11
- Failed deployments in the Activity log HOT 3
- Why the need of the same assignment "DenyAction-DeleteUAMIAMA" twice?
- Counts for Expired & Orphaned Exemptions are not incrementing
- PacSelector on Install-HydrationEpac HOT 5
- Schema for global settings - VSCode says "Property `$schema` is not allowed"
- `Set-AzPolicySetDefinitionRestMethod`: Say what file errored
- Unable to set the scope for Assignments and Exemptions on a subnets
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enterprise-azure-policy-as-code.