captainkube: docker build fails about phippyandfriends HOT 6 CLOSED

I made it works in this way, by modifying captainkube Dockerfile, like as follows below:

# Build
FROM golang:1.13.4 as builder

WORKDIR /build
COPY main.go .
RUN GO111MODULE=on; go mod init captainkube && go get k8s.io/[email protected] && go get -d -v
# temporary workaroud for https://github.com/Azure/phippyandfriends/issues/30
#RUN cd $GOPATH/src/k8s.io/klog && git checkout v0.4.0 && cd -
RUN CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo -o app .

# Run
FROM alpine:latest  

RUN apk --no-cache add ca-certificates
WORKDIR /root/
COPY --from=builder /build/app .
CMD ["./app"]

So, if briefly, change this line:
RUN GO111MODULE=on; go mod init captainkube && go get k8s.io/[email protected] && go get -d -v
And comment out this line:
#RUN cd $GOPATH/src/k8s.io/klog && git checkout v0.4.0 && cd -
Thats all.

from phippyandfriends.

How do you specify a version in an import?
I tried adding go get k8s.io/[email protected] before the existing go get in the Dockerfile, but I get cannot use path@version syntax in GOPATH mode.
I'm not a go person, but this seemed to be related to using a different structure for the libraries.

from phippyandfriends.

Thanks @maximsapiens, you got it! That's indeed fix the issue accordingly. And yes you are right we could now remove the temporary workaround we did there: #31.

Thanks for your contribution on this @maximsapiens, @soccerjoshj07 and @howardjones!

from phippyandfriends.

Not sure if it's directly related but just found this: google/gnostic#155

from phippyandfriends.

Definitely looks like related to this: kubernetes/client-go#741

from phippyandfriends.

I think if/when this pull request is approved, this should help us out. kubernetes/kubernetes#87802

edit-nvm

from phippyandfriends.