Giter VIP home page Giter VIP logo

Comments (7)

mabster avatar mabster commented on September 25, 2024 1

Have submitted a PR for this! Hope it's OK!

from sql-action.

mabster avatar mabster commented on September 25, 2024

Hmm I redacted the username and server name in my post above but I used angle brackets so GitHub removed the word "redacted" entirely. Rest assured the user id is set in the connection string. :)

from sql-action.

mabster avatar mabster commented on September 25, 2024

Have updated to the latest version but still getting the same error. My action looks like this now:

 - name: Apply EF migration script
        uses: Azure/[email protected]
        with:
          connection-string: ${{ secrets.CONNECTIONSTRING_PUCKA }}
          sql-file: ./migrate.sql

from sql-action.

mabster avatar mabster commented on September 25, 2024

OK I have a theory.

When I created my Azure SQL user, I did it in my database like this:

CREATE USER [my-user] WITH PASSWORD = '...';
ALTER ROLE db_owner ADD MEMBER [my-user];

So the user exists in my database but does not correspond to a "login". It therefore has no access to the master db.

When you try to detect the client IP address, you're doing this:

await exec.exec(`"${sqlCmdPath}" -S ${serverName} -U "${connectionString.userId}" -P "${connectionString.password}" -Q "select getdate()"`

... which is trying to connect to my server, but not to my database. So I'm guessing it will try to connect to master and fail.

Can you use the full connection string in your command so that it connects to the database directly rather than to master?

from sql-action.

mabster avatar mabster commented on September 25, 2024

Or alternatively, could this line:

await exec.exec(`"${sqlCmdPath}" -S ${serverName} -U "${connectionString.userId}" -P "${connectionString.password}" -Q "select getdate()"`, [], {

... have a -d "${connectionString.database}" parameter? My connection string says "Initial Catalog=..." but presumably "database' is the right property name for your connectionString object.

from sql-action.

github-actions avatar github-actions commented on September 25, 2024

This issue is idle because it has been open for 14 days with no activity.

from sql-action.

zijchen avatar zijchen commented on September 25, 2024

This was fixed in #104 and will be in the v2 release

from sql-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.