Deployment Fails with certain NPM modules about webapps-deploy HOT 7 CLOSED

Some sort of integrity error with @typescript-eslint/typescript-estree also happens with @typescript-eslint/visitor-keys

from webapps-deploy.

@Fish1 Take a look at npm/npm#16861

from webapps-deploy.

@Fish1 Take a look at npm/npm#16861

Will probably be able to take a deeper look on Monday. But if the solution is to upgrade npm, wouldnt that be in the control of this azure deployment script?

from webapps-deploy.

@Fish1 Oh, interesting. Looks like the Oryx Build is reusing the NPM cache. That looks like a bug in the Oryx build not this.

You can get around this by doing the build yourself before deploy

    steps:
      - uses: actions/checkout@master
      - name: Use Node.js ${{ vars.NODE_VERSION }}
        uses: actions/setup-node@v3
        with:
          node-version: ${{ vars.NODE_VERSION }}
      - name: npm install, build, and test
        run: |
          npm prune --production
          npm install
          npm run build:${{ github.ref_name }} --if-present
      - name: 'Deploy to Azure WebApp'
        uses: azure/webapps-deploy@v2
        with:
          app-name: ${{ secrets.AZURE_WEBAPP_NAME }}
          publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE }}
          package: ${{ vars.PACKAGE_PATH }}

replace npm run build:${{ github.ref_name }} --if-present with whatever your build script is (I use the repo branch name) and replace ${{ vars.PACKAGE_PATH }} with whatever your ultimate ./dist folder is.

from webapps-deploy.

So the issue with doing this is that we now have to upload about 138M of data to the deployment script. Now I compile typescript, then move the node_modules into the dist folder.

from webapps-deploy.

So the issue with doing this is that we now have to upload about 138M of data to the deployment script. Now I compile typescript, then move the node_modules into the dist folder.

@Fish1 As I pointed out in a different reply you should never be deploying node_modules to production. You can easily fix this by setting up a webpack build. Your deployment should drop from 138M to about 2M. There are 100s of articles on webpack with TS but this is the first one I found https://blog.logrocket.com/using-webpack-typescript/

Realistically, all you need is webpack in your package json and a webpack config file for TS.

from webapps-deploy.

Thanks for the help! Everything is working now. I just had to manually go into the server and delete all the files, because my disk was full. I suppose this issue should be closed, as it's more of an Onyx issue?

from webapps-deploy.