[XFCE] Clarifications needed on some changes since Redmond-Themes, for Windows 3.11 theme. about windows-3.11 HOT 7 CLOSED

781fd47 fixes this

from windows-3.11.

It could indeed be related. They use a common widget code (button.flat) and I don't remember tweaking it accurately for this theme. Will have a look.

I believe I reduced button radius from 3px to 2px, so that may explain the reduced roundness. I'll have a look at the source material and update you on this

from windows-3.11.

Also, with the latest version on this repo, I found that the buttons on some dialogs have some strange issues.

Using Firefox's close dialog (when you have multiple tabs open) for example. There would be a thick black border (plus a rounded border inside, with white between the square and rounded edges) on the Close Tabs button, while for Cancel button, there would be slightly visible black square edges.

However, I'm unable to screenshot this dialog with the issue visible using xfce4-screenshooter, as the problem would not appear when the dialog/button is not in focus. You can test this with Firefox, as it's easily reproducible.

from windows-3.11.

As of the most recent changes, the panel buttons look correct and no longer Windows 95-ish.

And for the bug with Firefox, this time I managed to get screenshots with the bug visible.

1. Close Tabs button in focus.
   

2. Cancel button in focus.
   

Currently I only see the issue with Firefox and I haven't seen the issue appearing in other apps yet.

from windows-3.11.

I'll have a look at that firefox dialog button

from windows-3.11.

Ok, so recently got back to maintaining the themes, replicated the bug. Possibly caused by some difference in outline radius. Will try to correct

from windows-3.11.

Yes, can confirm the issue has been fixed. 👍

from windows-3.11.