encoding error on handling status report about python-gsmmodem HOT 7 OPEN

probably fixed in the latest commit, please test.

from python-gsmmodem.

I was able to reproduce your issue inside unittest (based on provided responses). Probably your modem sends invalid time zone data (0x2C).

@fredyrommy What is your time zone? Should it be +10.5? Maybe +11?

from python-gsmmodem.

Maybe the negative sign is placed in the wrong nibble by the modem?
0x2C --> 0010 1100 --> remove sign from the second nibble -0010 0100 = 0x24 negative * 0.25 = -9h timezone.
https://en.wikipedia.org/wiki/Binary-coded_decimal#Signed_variations

Maybe this bit just should be ignored, then it would mean +9h.

@fredyrommy please let us know your timezone :-) Is it -9 or +9?

from python-gsmmodem.

Currently time zone value is shifted back:
0xC2 --> 0x2C --> 0xC2 --> 0x42
And afterwards:
0x42 --> 42 * 15 / 60 --> -10h

Edit:
I just found that it was too late and I made a mistake:

tzHexVal = int((tzHexVal & 0x0F) * 0x10) + int((tzHexVal & 0x0F) / 0x10)

instead of:

tzHexVal = int((tzHexVal & 0x0F) * 0x10) + int((tzHexVal & 0xF0) / 0x10)

I will fix that (and add check for parsed value inside unit test) as soon as @fredyrommy will confirm time zone. 🙂

from python-gsmmodem.

According to the country code used inside your data (+62) it should be Indonesia, which has three time zones: +7, +8 and +9. Additionally, one of timestamps is decoded correctly by an old code (2016-10-30 04:59:44+07:00), so I assume it should be close to +7.

Values 0x2C and 0x28 have small difference, so I thought that someone forgot about BCD-check:

0x2C + 0x06 = 0x32 --> 32 * 15min / 1hr = +8

@fredyrommy Is it correct?
This hot fix could be found in a8b449d.

from python-gsmmodem.

yes my timezone is UTC +7 Jakarta, Indonesia

from python-gsmmodem.

@fredyrommy is your issue now resolved? (see #42; download v0.12 release or clone repo)

from python-gsmmodem.