Giter VIP home page Giter VIP logo

Comments (6)

zertosh avatar zertosh commented on May 18, 2024

Yeah, I've known about this but I don't think there's a solution. Sublime can't match across new lines, but a single JSX tag can run multiple lines - in fact, it's a very common pattern:

<div className='PanelSearch'>
  Search<input
    className='PanelSearch-field'
   /* comments */
    onChange={this.onInputChangeHandler}
    onKeyDown={this.onInputKeyDownHandler}
    value={props.query}
  />
</div>

So we only match the opening part of the tag (e.g.: <Tag) then try to match attributes and comments, since those can be on another line.

from babel-sublime.

dashed avatar dashed commented on May 18, 2024

Are semicolons allowed inside JSX tags? If not, maybe that can be a heuristic to differentiate JSX tags from comparison operator.

from babel-sublime.

zertosh avatar zertosh commented on May 18, 2024

@dashed good call! Can you and @hawkrives give #33 a test drive before I merge it?

from babel-sublime.

zertosh avatar zertosh commented on May 18, 2024

@hawkrives I just pushed the fix for this issue in v2.0.0 - should be picked up by Package Control within the hour.

from babel-sublime.

hawkrives avatar hawkrives commented on May 18, 2024

Excellent. Sorry I didn't get around to testing this— today was a bit hectic. 

I'll see if I spot anything!

On Sat, Feb 14, 2015 at 10:28 PM, Andres Suarez [email protected]
wrote:

@hawkrives I just pushed the fix for this issue in v2.0.0 - should be picked up by Package Control within the hour.

Reply to this email directly or view it on GitHub:
#29 (comment)

from babel-sublime.

zertosh avatar zertosh commented on May 18, 2024

no worries!

from babel-sublime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.