Improve error handling about orbit-mvi HOT 2 CLOSED

You're using PublishSubject<Any> = PublishSubject.create() inside BaseOrbitContainer. Subjects are great, however, they are stateful in a damaging way: when they receive an onComplete or onError they no longer become usable for moving data. So you might wanna check Relays which are basically Subjects except without the ability to call onComplete or onError.

from orbit-mvi.

Thanks for the suggestion @mradzinski. I'll explain how I understand this - please correct me if I'm wrong and let me know your thoughts!

Relays for Orbit would help in cases where upstream observables that feed into the input emit errors. However with some recent changes in 1.2.0 we no longer expose the input subject outside of an OrbitContainer or OrbitViewModel so this removes the need for the relays (we actually had them in at some point but decided to remove the extra dependency).

Not sure if we should be concerned with using relays in case of downstream observables getting errors since this is usually a user error (typically not handling and wrapping exceptions) and pretty fatal so these are the cases that we need to handle somehow. In such a case, you wouldn't be able to reuse such an OrbitContainer - relay or not.

It is usually quite difficult to find the error after this happens, so at the very least we should provide a nicer stack trace. As far as handling this gracefully it remains to be seen how far we can get with this :)

from orbit-mvi.