Giter VIP home page Giter VIP logo

Comments (6)

retorquere avatar retorquere commented on September 26, 2024

It's possible but it's not just a setting. If you give me samples of what you do that causes these mails I can remove them; they annoy me too, just not to the point that I sat down and fixed it yet.

Oh and praise is always welcome ;)

from redmine_backlogs.

PaulNendick avatar PaulNendick commented on September 26, 2024

Thanks for such a quick response!

I believe these emails are sent any time we shuffle issues around in the master backlog view. The changes to the position are reflected in the issue itself.

Here are a couple screenshots that might help explain it a bit:

  1. moving an issue: http://dl.dropbox.com/u/2112959/backlogs-screenie1.png

  2. position updates: http://dl.dropbox.com/u/2112959/backlogs-screenie2.png

Paul

from redmine_backlogs.

jorgeuriarte avatar jorgeuriarte commented on September 26, 2024

the issue has been closed, but I'm not aware of any related commit?
I was thinking about tackling the task of disabling those emails, too, because they make our product planning sessions too noisy.

from redmine_backlogs.

retorquere avatar retorquere commented on September 26, 2024

The isue isn't closed, it's still open. Any help on this is most welcome, I've been trying to achieve this all day and it's driving me bananas.

from redmine_backlogs.

PaulNendick avatar PaulNendick commented on September 26, 2024

I can't claim to know anything of the redmine or backlogs code base or ruby yet, but shouldn't there be an event created whenever an issue is updated? And perhaps a callback sort of function that generates emails based on the deltas in that change?

If I have a look at the code, which module(s) should I start with?

from redmine_backlogs.

retorquere avatar retorquere commented on September 26, 2024

I now know a lot more about rails and redmine than I actually bargained for, but I think I got it. A fix is now on master. It took some hair pulling, and the final result is just a 3-line fix.

Yes, an event is fired when an issue is updated, and it's pretty easy to catch with an after_save or before_save (see lib/backlogs_issue_patch.rb), but the magic workings of the journal and its observers is pretty convoluted.

There is a cleaner way, feel free to explore it; the current patch simply disables all journaling for story positions. It would be nice if we could keep the journaling, but disable the mailing bit if all that was changed was the position. This is possible (see app/models/journal_observer.rb in redmine), and it'd mean the JournalObserver would have to be monkey-patched the way everything in our lib dir monkey patches core classes to skip the after_create if the journal has only events for a position change.

from redmine_backlogs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.