Comments (1)
There are a couple of things that get wired together for this ingestion e2e. The entity provider will create a location in the catalog with the wildcard intact, that will in turn be picked up by the UrlReaderProcessor
and treated as a "search" target here:
That in turn is gonna take us to the GitHubUrlReader
in this case, which in turn does an initial search request here:
backstage/packages/backend-common/src/reading/GithubUrlReader.ts
Lines 252 to 255 in f640129
If that response is not truncated, it will continue on to do individual fetches for each matching file over here:
This fetch I think we need to make sure doesn't happen for this case. I don't know if it is right now, but based on the error message it seems like it might. What would be better is if it instead falls through to do a full reading of the repo tree so that all files are available locally over here:
If we end up there we don't have any issues with individual file fetches, since it's all available upfront.
So to move this ahead we'd appreciate if anyone wants to validate the above hypothesis that the initial search is not truncated. If that ends up being the case, I think we should probably add some additional check that cases us to fall back to the read tree path in case of very large repos.
from backstage.
Related Issues (20)
- 🐛 Bug Report: The task viewing for scaffolder is not user-friendly due to squished components
- 🐛 Bug Report: Aggregate ownership of large groups fail due to p-limit hanging after hitting max concurrent limit in plugin-orgs HOT 6
- Backstage startup with permission denied for schema public on PostgreSQL 16 HOT 1
- 🐛 Bug Report: Kubernetes react -> Warning: validateDOMNesting(...): <ul> cannot appear as a descendant of <p>.
- Extract the `Scheduler` service to `backend-defaults` and deprecated the `backend-tasks` package HOT 2
- Extract test utilities from `backend-common` to the `backend-plugin-api` package
- Extract `isChildPath`, `resolveSafeChildPath`, `resolvePackagePath` from backend common to the plugin api HOT 1
- 🚀 Feature: update the documentation for Github Org Data HOT 1
- 🚀 Feature: Overriding breakpoints in `UnifiedTheme` HOT 1
- Introduction of Service Modules in the New Backend System HOT 1
- Create a replacement for the status check router in the new system and deprecated it from the commons
- Remove `ContainerRunner` and its implementations from the `backend-common` package
- 🐛 Bug Report: Previous and next Footer links overlay background contents in Techdocs (Chrome)
- 🚀 Feature: Improve auth handling in the proxy HOT 2
- 🐛 Bug Report: Unable to modify backstage background image
- Key for the ES256 algorithm must be one of type KeyObject or CryptoKey. Received an instance of Uint8Array HOT 11
- 🚀 Feature: React 19 Upgrade
- 🚀 Feature: Vulnerability report for backstage HOT 2
- 🐛 Bug Report: Github Auth not working on backstage version 1.26.0 HOT 10
- 🚀 Feature: Dynamic configuration fetching of frontend from backend HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backstage.