PSR-2 about handesk HOT 12 CLOSED

Style ci working :)

from handesk.

StyleCI.io

from handesk.

Hahaha, yeah I'm using a really big indentation to make the code breath, and make me feel wasted when a file starts growing so much, so I prefer using the { inline to avoid a bit of that big spacing,

I know laravel uses the PSR-2 approach but I'm not really into it yet..

from handesk.

Hi all,

i good in contact with php-cs-fixer from another project (https://mattstauffer.co/blog/using-php-cs-fixer-to-fix-up-your-php-code/) mabye we can use it ?
I can add it an make a PR ?

from handesk.

Ok sounds good, lets do it and see how it looks

from handesk.

Ok first try first loose ;)

php-cs-fix need sebastian/diff 1.4.x at the moment it's not working with sebastian/diff 2.x. see
PHP-CS-Fixer/PHP-CS-Fixer#2962

I guess we locked sebastian/diff to 2.x because of phpunit 6.3.

So i see 3 ways

1. install php-cs-fix local and global
2. downgreat packages so we can use sebastian/diff 1.4.x
3. wait for php-cs-fix to work with sebastion/diff 2.0

I recommend 3) over 2) over 1) :)

from handesk.

from handesk.

hmm "This package is abandoned and no longer maintained. No replacement package was suggested." i got on packagist.org ...

Short info ... i runned php-cs-fixer local and it's working fine - made files PSR2 conform - so just in case your editor or yourself use diffrent formats - the git will get PSR2 :-)

from handesk.

Just enabled it, but it tries to fix ide_helper.php too... i guess it is configurable right?

from handesk.

I tried to apply the style.ci PR but it makes the test fail

#49

I guess something is messed up, if anybody wants to play with the configuration.

It is the

.styleci.yml file

(I realy like to align the equals and arrays, so please, don't change that 😛 )

from handesk.

styleci uses php cs fixer and brings some more.
However it means it inheritances some issues for php cs fixer itself ;)

If you want to go for styleci and the help wanted label is still current I can ping the author here for you.

If you go for php cs fixer I'm happy to inform you that I'm resolving the diff 1.4 vs 2.0 ATM.
Let me know if you've other questions about php cs fixer, happy to answer those!

from handesk.

Hi @SpacePossum yeah, this issue and lavel is still current,
I'm really new into that PSR stuff so I have really 0 idea on how styleci really works so any help will be really appreciated and sure worth the learning,

from handesk.