Giter VIP home page Giter VIP logo

Comments (5)

christasich avatar christasich commented on August 17, 2024 1

@badsgahhl That would also be useful. I did mean whitelisting though. My personal issue comes from browsing www.slickdeals.net. I use this site to monitor deals. The links they use are often passed through multiple hops (slickdeals -> site 1 - > site 2 -> site 3 -> final url). I've looked into these domains and I feel comfortable whitelisting them all. I think the auto-refresh option would be useful for both toggling the switch on/off and when whitelisting.

WAsGkagESH

from pihole-browser-extension.

badsgahhl avatar badsgahhl commented on August 17, 2024 1

Ah ok, cool idea.

I will play around with it a bit and see how it harmonizes well together.

Maybe it will become an option that you have to activate in the settings, and you can deactivate it if you don't want to have it.

from pihole-browser-extension.

badsgahhl avatar badsgahhl commented on August 17, 2024 1

There will be now the option to "Reload current tab after Whitelisting" and "Reload current tab after Disabling".

Blacklisting makes problems with caching and makes not so much sense.
Enabling and reloading is the same.

from pihole-browser-extension.

badsgahhl avatar badsgahhl commented on August 17, 2024

@christasich Do you really mean "after whitelisting"? I think you mean the on/off switch?

Lets say you are on one of those redirecting domains where you go to 2-4 domains at once, and all of them are blocked.
You would then whitelist the first domain -> extension reloads the page -> you get to the second domain that is blocked.

This seems a little bit weird to me.
I would understand the following as more usefull, because you typically don't want to whitelist all of these redirecting domains.

My Solution:

You are on a blocked domain -> Press the pihole offline switch -> extension reloades and you get pass all domains as fast as possible.

Is this maybe the thing you want?

from pihole-browser-extension.

christasich avatar christasich commented on August 17, 2024

Yeah. I think opting into the setting is a reasonable way of handling it. It seems safer to have it off by default. Thanks for being responsive to the idea!

from pihole-browser-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.