Giter VIP home page Giter VIP logo

Comments (9)

tombh avatar tombh commented on May 19, 2024 1

Yeah I've been pondering it too and you're right, those values are not canonical enough. So I think something of an MVP would be a config setting defaulting to off, but when on would make an attempt at matching the user's colorscheme.

Another thing that might be nice is just a copy and paste snippet in the README. I had to remind myself of the highlight syntax.

from vim-buffet.

bagrat avatar bagrat commented on May 19, 2024

Thanks for raising this. I did not really think about this, but I definitely like the idea.

How would you consider doing this? E.g. link the default Highlight to some built in ones? What exact mapping/matching would you suggest?

from vim-buffet.

carlitux avatar carlitux commented on May 19, 2024

Really I don't know how to do that, I don't know how vim/nvim store color values.

from vim-buffet.

tombh avatar tombh commented on May 19, 2024

Is let g:terminal_color_0 = "#1b2b34" an nvim thing or for all vims? I see in the OceanicNext theme https://github.com/mhartington/oceanic-next/blob/master/colors/OceanicNext.vim#L170

from vim-buffet.

bagrat avatar bagrat commented on May 19, 2024

@tombh this looks like NeoVim specific. What are your trying to achieve?

from vim-buffet.

tombh avatar tombh commented on May 19, 2024

Oh, well it was maybe an answer for here - if you can expect a set of available terminal_color_* vars then maybe you could prefill vim-workspace colours with them?

from vim-buffet.

tombh avatar tombh commented on May 19, 2024

Oh! But just realised, they're set by OceanicNext itself, so it's nothing to do with the version of vim. So maybe these vars are something you can generally expect to see from themes?

from vim-buffet.

bagrat avatar bagrat commented on May 19, 2024

As far as I understood, these variables are optionally expected by NeoVim. Still I am not sure how this scan be done, as in the end, VimWorkspace would define the UI with fixed colors that would change based on the selected colorscheme. However, I don't fully imagine how that would work out, as anyway that's a matter of taste. @tombh if you have any ideas and could experiment with, please feel free to submit a PR and let's continue the discussion.

from vim-buffet.

bagrat avatar bagrat commented on May 19, 2024

Hey @tombh! I have gone for a full rewrite of this plugin, as the code became very messy and I was not able to add more to it. Now the code is much more readable and actually more efficient, so contributions will be much easier. The new code is still in the rewrite branch, but I will be merging it into master very soon.

I have tries to link the default highlight groups into the build in ones, but not really sure how I would match it exactly to the current colorscheme. But I have left it as a TODO with some handy helper functions. If you will have time and ideas, please try and play with those and see how it works out.

Also added an example of setting custom highlight groups.

from vim-buffet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.