Giter VIP home page Giter VIP logo

Comments (3)

mikemcdonald avatar mikemcdonald commented on June 26, 2024

The idea behind the minimum fee in v1 was to ensure that any rounding errors in favor of the trader would be offset by the swap fee.

I agree that not being opinionated on a fee bound is ideal, but need to be sure we understand where rounding errors can potentially favor traders and how much those can be amplified in multi-trade single txs

from balancer-v2-monorepo.

nventuro avatar nventuro commented on June 26, 2024

Rounding errors should not be affected by multi-trades, since each trade is computed and validated independently. Regardless, are you saying you'd like for us to be sure there's no way for LPs to lose value with a 0% fee due to rounding errors (because the minimum swap fee will always be slightly higher than those)?

from balancer-v2-monorepo.

nventuro avatar nventuro commented on June 26, 2024

Superceded by #38

from balancer-v2-monorepo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.