Comments (3)
dmf7z
commented on June 26, 2024
I would also add the Vault's swap function caller because is does not always equals from.
This is necessary because a Trading Strategy may have to trust the origin of userData that could be a specific Trading Script smart contract which is caller and not always from.
from balancer-v2-monorepo.
nventuro
commented on June 26, 2024
I'm not sure that's a direction we'd want to go in, why would a TS be restricted to a specific trade script? It seems overly restrictive.
from balancer-v2-monorepo.
dmf7z
commented on June 26, 2024
TS needs to whitelist one or many trade scripts in case userData needs some level of trust, avoiding any other caller to manipulate it.
from balancer-v2-monorepo.
Related Issues (20)
- Add Avalanche and Polygon ZK EVM as gauge types to checkpointer HOT 1
- Improve addresses JSON HOT 1
- `StableMath::_calculateInvariant` can, in fact, overflow HOT 3
- Redeploy batch relayer in L2s with reference to the pseudo minter HOT 1
- Allow a single gauge factory per gauge type in `GaugeAdder` HOT 1
- Remove `deployments/` package
- Address calling peekChainedReferenceValue in payable transactions
- Implement LZ bridge forwarder
- L2GaugeCheckpointer: fix checkpoint timestamp
- Develop new Avalanche root gauge for new LZ bridge HOT 1
- Adjust docs in CSP / `getRate`
- Seedless LBPs HOT 2
- ProtocolId Registry
- Develop Base root gauge factory
- BPT_IN_FOR_EXACT_TOKENS_OUT accuracy issue HOT 1
- Execution reverted: BAL#520 when calling joinPool on a Managed Pool to add ETH HOT 3
- Deployed npm packages are having missing files
- ComposableStablePoolFactory -> create error
- LogExpMath.pow gives unexpected result HOT 1
- Please deploy to Holesky Testnet HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from balancer-v2-monorepo.