balint42 / comic.js Goto Github PK

Hey! First of all thank you for this cool library. It works well with D3 v3. Do you have plans to make the library compatible with D3 v4?

Hi - just wondering if this library can support two.js, and if so how I would implement that. Thanks!

When passing HTMLCollection type arrays to magic it fails. To be fixed.

Hello, I love your library. However, with some complex curves, I came across an error on line 12685. The problem is that list == undefined and as such !list.length throws an error.

My fix was to edited the code to:

if(!list ) list =  {};
else if(!list.length) list = list._list ;

Applying magic sometimes creates nonsense results, probably due to the use of transform inside the SVG.

Hi
Just testing the framework and it seems not ready to work.

Just doing a simple example from your info:

COMIC.magic([ document.getElementById('ShowImagesInDB1'), document.getElementById('ShowImagesInDB2') ]);

and get this:
comic.js:639 Uncaught error: no drawing element given

How to use this function?
Also is there a callback?

I thought you might like to see your brilliant work applied in a slightly different (maybe unexpected) context as a htmlwidget for R. Here is a post explaining it.

Thanks so much for all your efforts with comic.js. I hope this post and application brings more attention to it.

Currently ellipses and circles sometimes seem to have edges and look strange. This could be caused by issues in the SVGtoEllipse method. To be investigated.