Giter VIP home page Giter VIP logo

Comments (1)

hasithaa avatar hasithaa commented on May 14, 2024

Please find my comments inline,

The grammar still has the concept of "connection". It's my understanding that we want to drop it.

Fixed.

The following looks strange to me - why do we need the ellipsis?

lastFormalParameter
: variableModifier* typeType '...' variableDeclaratorId
;
Fixed in current grammar.

Do resource parameters always include exactly one user defined type?

resourceParameters
: '(' userDefineType Identifier (',' formalParameterList)? ')'
;

Fixed in current grammar.

The grammar for "ifElseStatement" allows an empty "if" path as well as an empty "else" path:

ifElseStatement
: 'if' parExpression statement ('else' statement)?
;

Fixed in current grammar.

The same is true for "whileStatement":

whileStatement
: 'while' parExpression statement
;

Fixed in current grammar.

....but the syntax summary document requires at least one statement in "while".

Since the grammar defines the empty statement ";" as statement the "while" body should also support an empty body too. The same is true for "iterateStatement".

This is already addressed in current grammar.

from ballerina-lang.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.