Script doesn't like Umlauts: üöäÜÖÄßæøåÆØÅ about bank2ynab HOT 14 CLOSED

Might need to revert the UTF-8 encoding on read in line 26.

from bank2ynab.

Nope; I just changed it back to config.read(conf_files) but got the same error still.

from bank2ynab.

Try changing the encoding to latin-1. Link

from bank2ynab.

You mean encoding the downloaded file in Latin-1? It's a good test case. I'll check and report back.

This leads me to realize another question: Can we make the script either encoding-agnostic, or auto-detect the encoding and then either handle it accordingly or even convert the input file?

from bank2ynab.

from bank2ynab.

Change UTF-8 to latin-1 in line 26.
D'oh! :-) that's what you meant, sorry for misunderstanding. I'll test it at home.

from bank2ynab.

I tried running the UTF-8 version with ááááééééáá and had no problem with it.

from bank2ynab.

I'll have a go at it tonight and report back.

from bank2ynab.

Very odd! I get the above error regardless whether I have:
config.read(conf_files, encoding = "latin-1") or
config.read(conf_files, encoding = "utf-8")
I'm testing with your ááááééééáá and my üöäÜÖÄßæøåÆØÅ in separate and otherwise good test cases, see attached. I'm at a loss here.

elbi_umsaetze_20171018220326.csv.txt

from bank2ynab.

What happens if you remove the encoding bit from the function altogether?

from bank2ynab.

I'm curious to see if you still get this issue now after resolving issue #29.

from bank2ynab.

Sorry @nocalla but I still get errors when run with Python 2:

('Parsing file: ', 'elbi_umsaetze_20171022210838.csv')
('Using format: ', u'AT Raiffeisen Bank')
Traceback (most recent call last):
  File "bank2ynab.py", line 171, in <module>
    main()
  File "bank2ynab.py", line 163, in main
    output = clean_data(file)
  File "bank2ynab.py", line 71, in clean_data
    transaction_reader = csv.reader(transaction_file, delimiter = delim)
TypeError: "delimiter" must be string, not unicode

This is a different error than this one from the pull request.

It works with Python 3!

from bank2ynab.

Okay great! That's the python 2 failure we're getting for delimiters. It's a separate issue to the umlauts so this issue is resolved?

from bank2ynab.

If you say so then yes it's resolved! :-) I guess I can close it then.

from bank2ynab.