Giter VIP home page Giter VIP logo

Comments (2)

barelyhuman avatar barelyhuman commented on May 22, 2024

This is only in cases where the island renders an invalid semantic child,

example:

<p>
 <h1>
  Hello World
 </h1>
</p>

This is to be caught at the AST level since preact will go ahead and render it as sibling when the component is rendered with an island.

The other option is to generate a text node tree like fresh does but that would make the rendering a little more complicated.

from preact-island-plugins.

barelyhuman avatar barelyhuman commented on May 22, 2024

The reason for this is as listed in this issue
preactjs/preact#4093

Possible solutions

  • Wait for preact/debug to handle this
  • Handle it on the AST level with a DOM/JSX Tree sanitizer
  • Handle it on the AST level with a warning for known cases from the spec instead of sanitizing it

from preact-island-plugins.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.