Giter VIP home page Giter VIP logo

Comments (4)

Lastique avatar Lastique commented on August 19, 2024

BTW, re_global can become dangling since the re context may be deleted by re_thread_close or thread termination. For example, this breaks libre_close.

from re.

sreimers avatar sreimers commented on August 19, 2024

For the main thread re_thread_init should not be called, only for additional worker threads.

re_global is needed as fallback for re_thread_enter see https://github.com/baresip/re/wiki/Development-(re-usage)#thread-safety-for-non-re-threads

from re.

Lastique avatar Lastique commented on August 19, 2024

There is no "main thread" in our case. There can be any number of threads that are running separate instances of event loop.

re_global is needed as fallback for re_thread_enter

My suggestion is to remove the fallback. Require the caller of re_thread_enter specify the re instance he wants to use until re_thread_leave. Ultimately, there would be no global state in libre (other than TLS, perhaps), and the caller would be able to explicitly create and destroy re contexts and specify the context he wants to operate on. Basically, this would properly allow for multi-instance use of libre.

from re.

sreimers avatar sreimers commented on August 19, 2024

Removing the fallback would break existing applications, like the baresip android app. Can you try this PR: #404

from re.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.