Giter VIP home page Giter VIP logo

Comments (3)

Ghedeon avatar Ghedeon commented on June 8, 2024

Yes, I've looked at the code of PhotoViewAttacher and can confirm that paddings are ignored. Well, it can be fixed quite easy by using imageView.getWidth() - (imageView.getPaddingLeft() + imageView.getPaddingRight()) instead of just imageView.getWidth(). The same story with imageView.getHeight(), you should replace it with imageView.getHeight() - (imageView.getPaddingTop() + imageView.getPaddingBottom()). It's just three methods in the PhotoViewAttacher where you should do this changes: onFling(), checkMatrixBounds(), updateBaseMatrix().

Hope this will help you, @chrisbanes. @milek .

from photoview.

laurencedawson avatar laurencedawson commented on June 8, 2024

Just encountered this too, the fix provided by Ghedeon works nicely.

from photoview.

smarek avatar smarek commented on June 8, 2024

@laurencedawson @Ghedeon can you put together a pull request against dev branch? Would be nice, if you have the PhotoViewAttacher patched already.

from photoview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.