Comments (4)
mgeier
commented on July 19, 2024
Apart from this, there also some formal problems:
$ pep8 test_pysoundfile.py
test_pysoundfile.py:7:1: E302 expected 2 blank lines, found 1
test_pysoundfile.py:14:80: E501 line too long (84 > 79 characters)
test_pysoundfile.py:39:80: E501 line too long (83 > 79 characters)
test_pysoundfile.py:45:80: E501 line too long (85 > 79 characters)
test_pysoundfile.py:46:80: E501 line too long (84 > 79 characters)
test_pysoundfile.py:129:80: E501 line too long (81 > 79 characters)
test_pysoundfile.py:145:33: E231 missing whitespace after ','
test_pysoundfile.py:160:80: E501 line too long (84 > 79 characters)
test_pysoundfile.py:229:80: E501 line too long (80 > 79 characters)
test_pysoundfile.py:235:80: E501 line too long (84 > 79 characters)
test_pysoundfile.py:265:80: E501 line too long (85 > 79 characters)
test_pysoundfile.py:271:49: E231 missing whitespace after ','
test_pysoundfile.py:272:46: E231 missing whitespace after ','
test_pysoundfile.py:275:80: E501 line too long (94 > 79 characters)
test_pysoundfile.py:290:80: E501 line too long (84 > 79 characters)
test_pysoundfile.py:297:1: E302 expected 2 blank lines, found 1
test_pysoundfile.py:301:33: E231 missing whitespace after ','
test_pysoundfile.py:311:37: E231 missing whitespace after ','
test_pysoundfile.py:316:32: E231 missing whitespace after ','
test_pysoundfile.py:324:33: E231 missing whitespace after ','
test_pysoundfile.py:324:47: E261 at least two spaces before inline comment
test_pysoundfile.py:335:33: E231 missing whitespace after ','
from python-soundfile.
bastibe
commented on July 19, 2024
These are very valid points. Thank you!
from python-soundfile.
mgeier
commented on July 19, 2024
I think the tests about precision are not really necessary because they only test libsndfile.
I think it would be better to check for exact equality without the PCM <--> float conversion.
So either make a float test file and check with float32/float64 or make a PCM test file and test with int16/int32.
Or both.
It would be probably best to make a floating point test file with values which are accurately representable in both decimal and binary.
Something like [1.0, 0.5, 0.0, -0.5, -1.0], probably?
In stereo this could be [[1.0, -1.0], [0.5, -0.5], [0.0, 0.0], [-0.5, 0.5], [-1.0, 1.0]].
I guess 5 frames would be enough for most test cases.
from python-soundfile.
bastibe
commented on July 19, 2024
I am closing this issue. Discussion continues in #48 .
from python-soundfile.
Related Issues (20)
- Feature request: Support interleaved stereo data HOT 4
- buffer_read doesn't work in basic test HOT 2
- Soundfile read/write wav is not symmetric with default arguments HOT 3
- module 'soundfile' has no attribute 'SoundFileRuntimeError' HOT 5
- Value Error: array is too big when loading .flac file
- soundfile crashes when trying to export long .ogg file HOT 1
- soundfile.LibsndfileError: Error opening <_io.BytesIO object at 0x0000022B81C21850>: Format not recognised. HOT 2
- Cannot suppress warnings when decoding mp3
- Cannot open Ogg FLAC file: unknown error in flac decoder HOT 1
- miniforge3/lib/python3.9/site-packages/soundfile.py", line 1229, in _init_virtual_io def vio_get_filelen(user_data): MemoryError: Cannot allocate write+execute memory for ffi.callback(). You might be running on a system that prevents this. For more information, see https://cffi.readthedocs.io/en/latest/using.html#callbacks
- Cannot write Ogg files over 96 seconds long at 44.1 kHz HOT 4
- soundfile.info does not work on mp3 HOT 2
- soundfile.LibsndfileError: <exception str() failed> HOT 6
- How to save left and right channel in separate files? HOT 1
- soundfile.LibsndfileError: Error : unknown error in flac decoder. HOT 2
- "Format not recognised." for m4a files HOT 2
- soundfile.LibsndfileError: Error opening <tempfile._TemporaryFileWrapper object at 0x7feadae59070>: Format not recognised. HOT 2
- Part of mp3 is loaded. HOT 2
- unknown error in flac decoder HOT 2
- Capture libmpg123/libsndfile warnings HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-soundfile.