Refactoring about blog HOT 8 OPEN

@chrisgioia64
Great!

from blog.

The following source files have no explicit references to that class from somewhere outside that class.
More concretely, for NumberEvidence, running the command below produces 0

grep -r NumberEvidence blog/src/main/java | grep -v NumberEvidence | wc -l

@lileicc @cberzan I excluded files in distrib package because there is some designated way where the BLOG engine searches for all files in the distrib package. I included some sampling and inference classes since they have no references in the code but are referenced on the command line and don't know which ones are obsolete.

If you can mark the files below that can be safely removed.

To delete:

• ./absyn/NumberEvidence.java
• ./common/BinaryHeap.java
• ./common/CartesianProduct.java
• ./common/CountedIterator.java
• ./common/DenseVector.java
• ./common/Distance.java
• ./common/Experiment.java
• ./common/FibHeap.java
• ./common/FilteredMapIterator.java
• ./common/IncompleteOneToOneMappingsIterator.java
• ./common/IndexedTreeSetDiff.java
• ./common/IntegerDist.java
• ./common/MultisetBackedSet.java
• ./common/Mutable.java
• ./common/PrecisionRecall.java
• ./common/SetBackedMultiset.java
• ./common/SparseVector.java
• ./common/SubsetIterator.java
• ./common/SubstringReplacer.java
• ./common/TabularReader.java
• ./common/WeakHashSet.java
• ./translate/Translator.java (delete entire package)

To keep:

• ./engine/LiuWestFilter.java
• ./sample/GibbsSampler.java
• ./sample/LWImportanceSampler.java
• ./sample/modular/DiscreteECSSSampler.java
• ./sample/modular/ModularLWSampler.java
• ./sample/SimpleInstEvalContext.java

from blog.

@chrisgioia64 I marked the files to be deleted above. Also I think you can remove these:

• common/ImplicitVector.java
• test/blog/DistanceTest.java
• common/IndexedTreeSet.java

Thanks for doing this cleanup.

from blog.

@chrisgioia64

You may try to use eclipse to find reference for a specific class.

Do not remove anything under engine and sample, since they can be used from
commandline (-s or -e).

I agree that many of the files under common can be removed, or they should
be.

Lei

On Wed, Aug 20, 2014 at 3:09 PM, cberzan [email protected] wrote:

@chrisgioia64 https://github.com/chrisgioia64 I marked the files to be
deleted above. Also I think you can remove these:

• common/ImplicitVector.java
• test/blog/DistanceTest.java
• common/IndexedTreeSet.java

—
Reply to this email directly or view it on GitHub
#300 (comment).

from blog.

The following files are not reachable from src/main/java/blog/Main.java. Should I keep these?

• src/main/java/blog/common/IntegerGeometricSeriesIterator.java
• src/main/java/blog/DBLOGUtil.java
• src/main/java/blog/common/IntegerGeometricSeriesIterator.java
• src/main/java/blog/common/PermutationIterator.java
• src/main/java/blog/common/Heap.java
• src/main/java/blog/translate/Translator.java
• src/main/java/blog/common/OneToOneMappingsIterator.java
• src/main/java/blog/common/Configuration.java
• src/main/java/blog/common/DAEFunction.java
• src/main/java/blog/common/FilteredIterator.java
• src/main/java/blog/common/BinaryProcedure.java
• src/main/java/blog/common/IndexedSortedSet.java
• src/main/java/blog/common/RangeOperations.java
• src/main/java/blog/common/Permutation.java
• src/main/java/blog/common/Gnuplot.java
• src/main/java/blog/common/DependencyAwareEnvironment.java
• src/main/java/blog/common/EZIterator.java
• src/main/java/blog/common/IntegerGeometricSeriesIterator.java
• src/main/java/blog/common/BipartiteMatcher.java
• src/main/java/blog/common/IntegerArithmeticSeriesIterator.java

from blog.

@lileicc inside Absyn.java, why is printTree deprecated

from blog.

DBLOGUtil should not be deleted.
I will check all these files and remove them if necessary.

printTree is replaced by prettyPrinter

On Wed, Aug 27, 2014 at 10:54 AM, Christopher Gioia <
[email protected]> wrote:

@lileicc https://github.com/lileicc inside Absyn.java, why is printTree
deprecated

—
Reply to this email directly or view it on GitHub
#300 (comment).

from blog.

@lileicc Does issue #304 take care of the changes in the warnings branch?

from blog.