Giter VIP home page Giter VIP logo

Comments (4)

fmeum avatar fmeum commented on June 17, 2024 2

@aiuto The notes for the current release do not have this stanza in the release notes.

I would go as far as saying that a repo that is as fundamental as @platforms should not have any dependencies, at least not in a WORKSPACE world. Could the rules_license dep be moved to a subpackage that isn't part of the API of @platforms?

from platforms.

aiuto avatar aiuto commented on June 17, 2024 1

Yes. I see this repository does not have a deps.bzl pattern.
Rather than adding that piece of ugly. I'll update the release notes to include the a pointer to the workspace stanza for rules_license.

from platforms.

aiuto avatar aiuto commented on June 17, 2024

Currently that would be.

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_license",
    urls = [
        "https://github.com/bazelbuild/rules_license/releases/download/0.0.4/rules_license-0.0.4.tar.gz",
        "https://mirror.bazel.build/github.com/bazelbuild/rules_license/releases/download/0.0.4/rules_license-0.0.4.tar.gz",
    ],
    sha256 = "6157e1e68378532d0241ecd15d3c45f6e5cfd98fc10846045509fb2a7cc9e381",
)

from platforms.

jwnimmer-tri avatar jwnimmer-tri commented on June 17, 2024

... should not have any dependencies ...

As a user, I would prefer this. However, in the meantime ...

... the notes for the current release do not have this stanza in the release notes ...

... we should at least document the status quo. I've filed #82 for that.

from platforms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.