Comments (6)
"Without a result" presumably meaning the default ActionResult
instance? Hard to make a request otherwise.
Incidentally, can you refer to the documentation where this permission is enumerated here? I went looking for something similar recently, and I think we need the language associated with the permission to agree on action anyway.
from remote-apis.
I don't recall why RBE has an action 'delete' permission - most likely the permission exists but with no associated methods that leverage it. What is your use-case that needs Delete?
Whatever the reason, I have no specific objection to a Delete* method for actions, if you have a reason to need such a thing. But I also haven't encountered much call for it, and will note that RBE has no such need (or method) today*.
* Through the front door, anyways - we remove AC entries with garbage collection, for example, but that's an implementation detail.
from remote-apis.
Google's RBE permissions are documented here: https://cloud.google.com/iam/docs/permissions-reference (search for remotebuildexecution)
@werkt: the Java protobuf API does distinguish between unset protos and default protos, it only doesn't allow doing this for primitive types.
We may need an API to delete malformed, broken, or malicious action cache entries. Technically, overwriting an action cache entry may also be possible by setting skip_cache_lookup=true
, but that incurs the cost of re-executing the action, and the service typically only writes an entry if the exit code is zero.
from remote-apis.
Conceptually I have no objection to an explicit delete API. We originally opted not to implement one at least in part because constructing the digest to delete is relatively difficult, but that was purely a pragmatic decision based on the client tooling available at the time.
from remote-apis.
I'd vote in favour of an explicit delete in preference to overloading UpdateActionResult. Agreed that this is a useful thing in practice.
We might want to consider extending ActionCacheUpdateCapabilities to indicate whether delete is enabled (or clarify that update_enabled
covers both).
from remote-apis.
In concept I would agree. @ulfjack, would you mind bringing this back to the mailing list to ensure broader visibility of the question? If you already have a proposal for the DeleteActionResult API, maybe open a WIP PR?
from remote-apis.
Related Issues (20)
- Compression: Further specify ByteStream WriteResponse committed_size field for compressed blobs HOT 1
- How does GetCapabilities() interact with authorization & unknown instance names? HOT 3
- Git tags for minor versions
- Non-Bazel Server Example HOT 3
- Replace message Tree with a topologically sorted varint delimited stream of Directory messages HOT 1
- REv3 idea: Make is_topologically_sorted the default, and eliminate tag bytes
- Let exit_code be better aligned with C/POSIX
- REv3 idea: Make use of digest_function in requests mandatory
- REv3: Use IPLD (CIDs, DAG-PB, etc.)
- Chyba
- CAS: Existence Caching in Intermediate Caches (user experience report) HOT 2
- Please tag REv2 2.1.0 2.2.0 [...] HOT 6
- API extension for Git hashes HOT 1
- Googleapis is outdated HOT 1
- Should we make a resolution to NOT have a v3? HOT 2
- Support compression with external dictionary HOT 6
- Add supported_max_cas_entry_size property to CacheCapabilities HOT 2
- Bazel version to use to run hooks/pre-commit unclear HOT 1
- REv3: Reduce asymmetry between O(n) output files and O(1) output directories HOT 2
- Platform standardization HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from remote-apis.