Giter VIP home page Giter VIP logo

Comments (3)

ola-rozenfeld avatar ola-rozenfeld commented on June 23, 2024

Oh, it was changed on purpose, because we now allow modifying the working directory: https://github.com/bazelbuild/remote-apis/blob/master/build/bazel/remote/execution/v2/remote_execution.proto#L478
The feature was introduced because some existing clients prefer to run their actions in the root directory of a VM, and rely on some absolute paths (IIRC). The working directory is equal to the input root by default, though -- maybe we should have mentioned this again in the output files/dirs documentation?

from remote-apis.

t-chaik avatar t-chaik commented on June 23, 2024

Thanks for the details @ola-rozenfeld!

Isn't it misleading for OutputFile.path and OutputDirectory.path not to be relative from the same root? I'm fine either input root or working directory, but I find the inconsistency quite error prone...

from remote-apis.

ola-rozenfeld avatar ola-rozenfeld commented on June 23, 2024

Oh! Haha, yes, sorry, I only now understood you fully -- yes, it's supposed to say working directory everywhere, of course. Fixing now. Thank you!

from remote-apis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.