Comments (5)
from rules_android.
Hi Mauricio,
What do you think about changing the acls.bzl behavior to return True for all external repos? I'm not sure what really can/should be done for external ACL support, since technically users can name external repos anything they want, so there's essentially an unbounded set of possible targets to consider.
from rules_android.
Hi Mauricio,
What do you think about changing the acls.bzl behavior to return True for all external repos? I'm not sure what really can/should be done for external ACL support, since technically users can name external repos anything they want, so there's essentially an unbounded set of possible targets to consider.
Yeah I think that works, most of this acls only make sense in the context of google. Internally we are already defaulting all acls to a sensible default.
from rules_android.
Internally we are already defaulting all acls to a sensible default.
I suspect that most power users will have to do something similar, either with a soft fork of the codebase or a patch command to http_archive() (or the bzlmod equivalent), at least with the current way that ACLs are implemented. The only alternative I can think of where we can expose these ACL settings to users with zero code modifications is by proliferating hundreds (?) of constraints, which is pretty ugly.
from rules_android.
@mauriciogg I landed the fix that defaults ACLs to true. If this resolves things on your end I think we can close this issue.
from rules_android.
Related Issues (20)
- Can't build example basicapp HOT 5
- _copy_file and _copy_dir fail on macOS
- AAR libraries from Maven don't expose their resources unlike in built-in Android rules HOT 3
- Mobile install v3 doesn't work with --start=debug HOT 1
- Flags underneath rules/flags/ aren't working correctly HOT 1
- Android platforms breaks incremental dexing and desugaring HOT 4
- mobile-install fails with dependencies from rules_jvm_external HOT 7
- Unable to build with rules_android due to maven install issue HOT 2
- [Bazel CI] android_sdk_repository & android_sdk_repository_platforms_tests are failing with Bazel@HEAD HOT 1
- Bazel query broken at HEAD
- [Bazel CI] ERROR occurred during the fetch of repository 'rules_android_maven'
- APK doesn't include *.version files in metadata
- Rules use entire Android SDK dir as input instead of explicit files which may case poor cache hit HOT 1
- documentation for targets under android_sdk_repository
- Bash is not necessarily in /bin/bash
- No matching toolchains found for types @@bazel_tools//tools/android:sdk_toolchain_type even though called register_toolchains HOT 2
- [FR] Option for mobile-install command to install to all connected devices
- Incomplete implementation of android dynamic features HOT 5
- mobile-install not fully open sourced HOT 6
- Migrate all providers to Starlark HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rules_android.