Giter VIP home page Giter VIP logo

Comments (8)

ahumesky avatar ahumesky commented on September 24, 2024 1

That the rule is incidentally creating build files in the real NDK directory is a known issue: #3

I'll work on solving that next

from rules_android_ndk.

keith avatar keith commented on September 24, 2024

The terraform changes in bazelbuild/continuous-integration#1425 should solve this, it will create a pipeline for this, someone will have to hook up webhooks though

from rules_android_ndk.

meteorcloudy avatar meteorcloudy commented on September 24, 2024

I have set up the webhook, the presubmit is available for PRs now, see #13 and https://buildkite.com/bazel/rules-android-ndk/builds/2

But there are some failures, it looks like you are trying to put a BUILD file in the Android SDK installation directory? On Bazel CI, that directory is mounted in the docker container from the host VM, so it's not writable. Is there a way to avoid doing that?

See https://github.com/bazelbuild/continuous-integration/blob/d0accaf7a76e9f4f58f4773dcccb5233882e9b97/buildkite/terraform/bazel/pipeline.yml.tpl#L32

from rules_android_ndk.

ahumesky avatar ahumesky commented on September 24, 2024

Looks like we'll also need to update the version of the NDK on CI:
#13 (comment)

from rules_android_ndk.

ahumesky avatar ahumesky commented on September 24, 2024

Presubmit should now work for linux:
#14 (comment)

It may take some time for mac to be set up

Some commits in the course of setting this up:
40e17b3
9caf964
254cb3b
2a3c13b

from rules_android_ndk.

keith avatar keith commented on September 24, 2024

I think we're all good here

from rules_android_ndk.

ahumesky avatar ahumesky commented on September 24, 2024

it would be good to also run the apk that's built on an emulator, to make sure the artifact actually works, something like what's done here:
https://github.com/DanAlbert/ndk-app-template/blob/f1558c77f4ac563ccfc1dbd41222d4616900b5ba/.github/workflows/build.yml#L63

but that can be its own issue

from rules_android_ndk.

ahumesky avatar ahumesky commented on September 24, 2024

#23

from rules_android_ndk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.