Better docs for image substitutions about rules_k8s HOT 3 CLOSED

At least today XXXX has to be a well-formed and fully-qualified image name. This means, there must be a domain part (e.g. gcr.io) and a tag (e.g. :latest). We could conceivably relax this by disabling strictness in the docker_name.Tag, or allowing the keys to replace arbitrary strings. If this sounds appealing let's fork another issue for that piece?

I think the crux of this is that you want this:

I also tried $(GCP_REGISTRY)/$(GCP_PROJECT)/web-frontend ...

These rules currently support stamp variables (IIRC), but not make variables (which I find annoying without vardef for defaults). That said, stamp variables in the key of images={} isn't super useful without a templating system with similar stamping support (related).

... where GCP_REGISTRY and GCP_PROJECT are defines in my bazelrc

This is where image_chroot comes in. It allows you to rewrite an embedded reference into a developer namespace. It's a bit ugly with strict names, but you can insert a dummy name and aways chroot it. We do this in the examples (in part) for integration testing these features.

Let me know if there is anything I didn't speak to.

from rules_k8s.

Using image_chroot result in extra folders in the registry, right? I would add
image_chroot = "$(GCP_REGISTRY)/$(GCP_PROJECT)/" into the k8s_defaults in workspace and use
image: gcr.io/robco:latest in my deployment.yaml. This would then create gcr.io/robco folders in the registry. I agree that by this we can probably "make thinks work"™, I would not be fond of it.
1.) the extra folders are confusing especially if one is called gcr.io and located on eu.gci.io.
2.) the fact that things get replaced in the yaml file are not obvious, becasue we replace a plaintext string

from rules_k8s.

So this is sort of an artifact of how this grew up, and it certainly isn't immovable :)

Essentially, we started from a point where the yaml templates basically had to be independently useful, since the only modifications we performed were tag => digest. With chrooting, the game changes considerably.

Let me TAL to confirm that this is a simple change (ideally by making it), and then we can replace arbitrary strings with digests.

from rules_k8s.