Giter VIP home page Giter VIP logo

Comments (5)

ensonic avatar ensonic commented on May 24, 2024

A workaround for this is to change the deployment.yaml and use `:latest'.:

apiVersion: extensions/v1beta1
kind: Deployment
spec:
  replicas: 1
  template:
    spec:
      containers:
      - name: web-frontend
        image: web-frontend:latest

from rules_k8s.

greggdonovan avatar greggdonovan commented on May 24, 2024

We've had to work around this via an image tag, too. What do you think about using the Python Kubernetes client library to parse the YAML (rather than just walking the untyped YAML? Then we could just replace the image references using the typed structure the K8s Python client would give us.

Picking the right client version seems like the tricky part, as the rules don't have a notion of version yet.

from rules_k8s.

mattmoor avatar mattmoor commented on May 24, 2024

That wouldn't work well with CRDs, or with image names in contexts other than a corev1.Container's image: field.

e.g. in WarmImage I am using this to pass the digest of a sidecar I'm injecting into DaemonSets: https://github.com/mattmoor/warm-image/blob/master/release.yaml#L39

from rules_k8s.

greggdonovan avatar greggdonovan commented on May 24, 2024

@mattmoor I've come around to your view here. In fact, I propose an even more flexible expansion policy in #134, motivated by a workaround we have where the full YAML of an init container needs to be encoded as JSON and stuck into spec->template->metadata->annotations.pod.beta.kubernetes.io/init-containers. Maybe we just need better documentation on how this works and recommendations for using flexible image replacement without getting burned?

from rules_k8s.

fejta avatar fejta commented on May 24, 2024

Looks like this has died

from rules_k8s.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.