ci.bazel.io build is broken about rules_scala HOT 12 CLOSED

/cc @johnynek fyi

from rules_scala.

@damienmg I think this came from removing jdk but what confuses me is that we are not explicitly using it. We are using jar and a bazel rule that itself depends on jdk.

Is seems strange that depending on jar alone is not enough (shouldn't it declare its dependendency on jdk?) and a rule that depends on something that depends on jdk (i guess the OSX error) shouldn't also be needed right? Otherwise users need to add the transitive deps, which seems wrong to me.

from rules_scala.

okay, this is an issue with 0.2.1 vs 0.2.2. The runfiles path changed to include the workspace name in 0.2.2. I'll fix this for 0.2.2 head when the homebrew rule ships, until then I assume a good group of people are still on 0.2.1 (including our devs at Stripe).

from rules_scala.

PS: I installed a VM with linux to test this, so I am fairly confident that I can repro the failures now. It would be great if we had a CI on the PRs so we didn't need to rely on this or pings from you, but I know I have mentioned that before.

In this case, bazel really changed between minor releases, so I don't see how we could have been correct without branches.

from rules_scala.

So the Linux error is because we cannot create executable filegroup with multiple files. So jar is a filegroup that point to the jar binary but the jar binary still requires some other library. On Linux we sandbox and undeclared dependencies doesn't get mounted in the sandbox, therefore the error.

The workspace name issue got fixed on version 0.2.2 (it got broken with load statement in the workspace file). Unfortunately, we have another problem and it is not yet merged in Homebrew (for a different reason).

@kchodorow have proposed a patch to TensorFlow Serving for making their use case works on both version.

I am still working on vetting PR. I have to cut the Bazel job in two for that and it's breaking currently because we have ourself an incompatible change. Sorry for that taking so long.

from rules_scala.

fyi we have deactivated the test until this bug is fixed. I have a fix for homebrew so I probably do a new release in the following days

from rules_scala.

Okay. Sorry about dragging on this. After the new release I'll try to add a
Travis CI build for multiple versions of Bazel so we don't have this issue
in the future.

On Wednesday, May 4, 2016, Damien Martin-Guillerez [email protected]
wrote:

fyi we have deactivated the test until this bug is fixed. I have a fix for
homebrew so I probably do a new release in the following days

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#49 (comment)

P. Oscar Boykin, Ph.D. | http://twitter.com/posco | http://pobox.com/~boykin

from rules_scala.

No problem, after the new release I should be able to activate PR vetting
(it's blocked because someone introduced yet another incompatibility in
Bazel, so we cannot build bazel with 0.2.2 either...).

On Thu, May 5, 2016 at 8:54 AM P. Oscar Boykin [email protected]
wrote:

Okay. Sorry about dragging on this. After the new release I'll try to add a
Travis CI build for multiple versions of Bazel so we don't have this issue
in the future.

On Wednesday, May 4, 2016, Damien Martin-Guillerez <
[email protected]>
wrote:

fyi we have deactivated the test until this bug is fixed. I have a fix
for
homebrew so I probably do a new release in the following days

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
<
#49 (comment)

P. Oscar Boykin, Ph.D. | http://twitter.com/posco |
http://pobox.com/~boykin

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#49 (comment)

from rules_scala.

@damienmg should be fixed by #54 would be great to get added to CI again.

(I checked our tests on my linux vmware install, which passed).

from rules_scala.

@damienmg can you close this when you re-add us to CI?

from rules_scala.

Sure I am doing that right now :)

from rules_scala.

And it is green and you have PR vetting now.

You should accept the invitation to the bazelbuild org and make it visible so you can trigger yourself the builds :)

from rules_scala.