URLDataSource uses source data name about simple-java-mail HOT 5 CLOSED

Can you provide some example code where this happens?

from simple-java-mail.

MimeMessageHelper#getBodyPartFromDatasource is pretty clear. If dataSource.getName() returns null or empty then it uses the name specified in the Attachment. Otherwise it uses the source resource's name.

I imagine any test code I show you won't be too insightful beyond the above, as my usage is pretty benign (thanks to your clean api). To reproduce you can add an attachment like,

URL url = new URL("https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png");
email.addAttachment("logo.png", new URLDataSource(url));

and the email will have a file named googlelogo_color_272x92dp.png instead of logo.png.

from simple-java-mail.

I've been refactoring this part for the past hour and I think it will be solved now with the next release.

/edit just tested your case which was working correctly now.

from simple-java-mail.

Thanks! 👍

from simple-java-mail.

Released in v4.1.0.

from simple-java-mail.