Comments (7)
bchavez
commented on May 18, 2024
Hi @JvanderStad , right-o and on point, I think your assumption is correct. Seed is only predictable on the random values pulled from Seed.Next. So, if the number of calls to Next changes it can disrupt the unit tests expected output.
from bogus.
JvanderStad
commented on May 18, 2024
thanks 👍
I'll fix the tests, pr coming soon..
from bogus.
bchavez
commented on May 18, 2024
You bring up a good point tough... If you checkout Person.cs, a person is being Initialized (and values pulled including address) when a Faker is constructed. The more correct way is to probably lazily delay person initialization this until a person is actually needed. I think this is what's goofing up the unit tests for you :(
from bogus.
JvanderStad
commented on May 18, 2024
I've created 2 new methods: GetRandomValue() and ParseTokens the ParseTokens is recursive. So the amount of calls to Seed.Next is changed by my commit.
Also, I made another branch with lazy loading the Person.. JvanderStad@6695892
from bogus.
JvanderStad
commented on May 18, 2024
from bogus.
bchavez
commented on May 18, 2024
SUPER cool! Thanks so much. I'll get a release out today for you.
from bogus.
bchavez
commented on May 18, 2024
@JvanderStad You changes are live in v5.0.1 and v5.0.1-beta-2. Thanks again for your contribution! Should appear soon when nuget index catches up.
https://www.nuget.org/packages/Bogus/
Brian
from bogus.
Related Issues (20)
- Bogus is slow on Blazor WASM HOT 1
- Add Amka number (Greek social security number) to Extensions.Greece
- Option to filter out en_AU_ocker
- Generating a deep object graph based on rules HOT 1
- Xamarin fails to publish due to Nordic characters in Method names HOT 2
- Add Direct License Information In Nuget metadata HOT 2
- Foreign Key Constraint Violation Issue with Bogus and EF Core
- Binder throw ambiguous match exception for object with read only indexer property that has two implementations in base class HOT 2
- First and Full names are incorrectly generated with locale "sv" HOT 2
- Request to add language English (Hong Kong) / locale en_HK
- Faker.Tv() is missing from Bogus.Hollywood HOT 3
- Feature request: New localized data: Word(s).
- Add ability to except random numbers HOT 2
- Update Denmark (da) locale from faker-js
- Nuget for .NET 8.0.x HOT 4
- Random history facts generation
- Are Randomizer's number ranges inclusive or exclusive? HOT 3
- bogus is missing NuGet package README file HOT 1
- .NET 8 support HOT 9
- Gender-digit is incorrect for Swedish Personnummer generation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bogus.