Giter VIP home page Giter VIP logo

Comments (4)

hemmoleg avatar hemmoleg commented on September 6, 2024 1

oh ok. well thank you for the explanation :)

from galeforce.

b-cho avatar b-cho commented on September 6, 2024

Hello @hemmoleg!

I believe that the DTOs for request responses should already be available for use. (Potentially redefining type Info = Galeforce.dto.MatchDTO['info']; could help?)

Code example:

import Galeforce from 'galeforce';

const galeforce = new Galeforce({
  'riot-api': {
    key: 'RGAPI-xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx',
  },
});

type Info = Galeforce.dto.MatchDTO['info'];

(async () => {
  const matchInfo: Info = (await galeforce.lol.match.match()
    .region(galeforce.region.riot.AMERICAS)
    .matchId('NA1_1234567890')
    .exec()).info;
  console.log(matchInfo);
})();

Please let me know if this works for you!

from galeforce.

hemmoleg avatar hemmoleg commented on September 6, 2024

Hello bcho04,

thank you very much for your answer. that does indeed work for me. However it still seems like kind of a hack, so just out of curiosity: why dont you just export the other interfaces as well?

from galeforce.

b-cho avatar b-cho commented on September 6, 2024

@hemmoleg

There are a couple reasons why I'm currently not exporting all of the lower-level interfaces for the DTOs; there's some name collision with the actual interface names, they're accessible as properties of the top-level interfaces corresponding to the API return values, and the sheer number of them (and their internal nature) makes it somewhat messy to export all of them directly.

from galeforce.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.