Comments (7)
taj
commented on June 3, 2024
2
@gemantzu i was able to reproduce this bug locally
I will open a PR to fix this!
from elixir-companies.
taj
commented on June 3, 2024
2
I think the way this works is fine! :)
The issue is caused by an edge case that no one thought of or tested. I don't think I would have caught it if it didn't cause the site to crash at all!
I have opened a PR for it, please review :)
from elixir-companies.
doomspork
commented on June 3, 2024
@gemantzu is this still a bug?
from elixir-companies.
gemantzu
commented on June 3, 2024
Yes! If you see the pending changes on the production system, they can't be handled and they produce an error.
from elixir-companies.
taj
commented on June 3, 2024
it doesn't seem to be a problem for me anymore?
Can you still replicate this? @gemantzu @doomspork
from elixir-companies.
gemantzu
commented on June 3, 2024
hey @tajchumber ! I was now able to reject the changes with not a company id on them (wasn't able to before), but the last one cannot be handled (the delete one). Checking on the actual issue now.
from elixir-companies.
doomspork
commented on June 3, 2024
Hooray! Thanks for helping get this resolved @tajchumber.
@gemantzu / @tajchumber I'm happy to re-think the way we do these pending changes if think there may be a better way?
from elixir-companies.
Related Issues (20)
- company slugs HOT 1
- Profile page button placement (only in production for some reason) HOT 2
- job showing in recent while it is deleted. HOT 5
- :single_one_for_one deprecation HOT 7
- LiveDashboards enable metrics and request logger
- Switch from Heroku to Gigalixir HOT 3
- search or filter by location HOT 2
- Edit function does not appear to work HOT 8
- Adding company process not explained on website itself HOT 2
- Company Profile Modal Close Error HOT 1
- Website is down HOT 13
- New Elixir companies website HOT 3
- Static image assets not correctly handled during build HOT 1
- Thank you 😁 HOT 2
- Cannot trigger `load_more` event when scroll down HOT 1
- Search by company name or industry is not working HOT 3
- Update `get_company!` to work without Ecto HOT 3
- Properly format markdown in descriptions HOT 1
- Add CTA for adding new companies that links to GitHub
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elixir-companies.