Qt client: a broken possibility for change status message function about teamtalk5 HOT 14 CLOSED

from teamtalk5.

@CoBC yes but in that time i didn't know the code and that issue got closed just because no one opened any pull request: so cab you please open the pull request this time and we will see if it gets confurmed? please, thanks to you.

from teamtalk5.

if i could, i would open pull request my self and would see if it would get murged as i'm asking for something that makes sence, just idk why github doesn't let me ad this repo, i think i don't have that right, and i'm having some problems with it, thanks.

from teamtalk5.

@CoBC if i want to be able to open pull requests i should creat a fork of this repo in to my account: correct?

from teamtalk5.

from teamtalk5.

Note, however, the line you mensioned previously isn't the only one thing to change to reply to your request, the action to change status call a library function (TT_DoChangeStatus) when used, so, if you call this function without be logged in to a server, this will fail, so you have to change behaviour of slot change status and check if the client is authentified or not to the server and adapt the code according to this.

from teamtalk5.

do i check the box that says copy master branch?

from teamtalk5.

Just let default options

from teamtalk5.

yes i understand, but i just want to remove this so it doesn't enable this option only if the client is auth wich means authorised and connected as i see what auth does in the bool auth: right?

from teamtalk5.

ok i did this: now i choose bace repo as amirmahdifard and head repo as bearware: right?

from teamtalk5.

Yes, but no, as I said previously, you can't change it just with removal of bool auth in this line.
And yes, you're right for fork, anyway I think it's not the apropriate way to talk about it, open a discussion, read GItHub doc or go in private to talk about fork, PR ant other.

from teamtalk5.

@CoBC ok: so will you open a pull request for this time, or no? if no, i will close this and reopen it whenever i can do it: or if you can, i ask you to do this please, however, you can answer freely ahat will you do about this so i know it too: thanks!

from teamtalk5.

@CoBC do you mean this part of the code? i found this that only allowes tt do change status if the client is authorised, but this is related to the toggle question mode option.
void MainWindow::slotToggleQuestionMode(bool checked)
{
if(checked)
m_statusmode |= STATUSMODE_QUESTION;
else
m_statusmode &= ~STATUSMODE_QUESTION;

QString statusmsg = ttSettings->value(SETTINGS_GENERAL_STATUSMESSAGE).toString();
if(TT_GetFlags(ttInst) & CLIENT_AUTHORIZED)
    TT_DoChangeStatus(ttInst, m_statusmode, _W(statusmsg));

}

from teamtalk5.

there's also a fue more but they are related to the idle timers and stuf, they are not about this option in the me menu.

from teamtalk5.