Giter VIP home page Giter VIP logo

Comments (5)

beeinger avatar beeinger commented on June 29, 2024 1

I have just rewritten the package to eliminate styled-components which were unnecessary in this case, everything works the same apart from the customGlobalCss parameter. No more warnings and it's way faster, cleaner and flexible.

from next-progress.

bitfella avatar bitfella commented on June 29, 2024

Same here. Using next 12.0.7, styled-components 5.3.3 and next-progress 1.0.8.

I see this happens because in line 34 of index.tsx styles are defined inside the component itself.
They should be defined outside, instead; passing color, customGlobalCss and height props to them.

Are pull requests welcome on this repo? Thanks @beeinger

from next-progress.

beeinger avatar beeinger commented on June 29, 2024

Yeah sure! Sorry for late response

from next-progress.

siamahnaf198 avatar siamahnaf198 commented on June 29, 2024

But solutions?

from next-progress.

bitfella avatar bitfella commented on June 29, 2024

@siamahnaf198 no solutions out of the box, the module should be fixed as stated above. Gonna see if I got time in the next days to take care of that and make a proper pull request to the repo owner. In the meanwhile, have a great weekend 🍻

from next-progress.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.