#build --> #find? about classy_enum HOT 4 CLOSED

find was an alias for build in pre 3.0, but when I was going through and cleaning things up for 3.0, I realized that build was doing significantly more than it did when I first introduced it. It was no longer just finding the enum type from within an hash, it was also setting some additional properties on it that came from the ActiveRecord classy_enum_attr call, such as the owner reference and how to serialize it. The TypeError message it returns is also not consistent with either Ruby's find which returns nil, or ActiveRecord's find which raises a ActiveRecord::RecordNotFound. Consistency was my biggest goal for the 3.0 refactor, and with this being one of those inconsistencies, I decided to remove it.

Having said that, I'm definitely not opposed to reintroducing find in another form for a 3.1 release. If implemented properly, I think it would make a lot of sense. I would probably write it as something like the following where all it's doing is just instantiating a new enum or returning nil if it cannot be found:

def find(value)
  return unless all.map(&:to_s).include? value.to_s

  "#{base_class}::#{value.to_s.camelize}".constantize.new
end

from classy_enum.

Ah, okay. That makes a lot of sense. I'm less peeved now. :)

I (and my team) would love it if you brought back the simpler find in the future.

from classy_enum.

So it looks like the future is more like a couple days :) It turns out I had to add I18n translation support for a work project today, and I'll be releasing a new version (3.1) either this weekend or early next week. Part of that upgrade is going to include find and possibly everything that comes with the Enumerable module. I started a branch but want to sit on it for a little while before I commit to it for 3.1. Here's a preview of the functionality, but I may change it slightly before the release.

from classy_enum.

Just released v3.1 which brings back find, and includes everything else that comes with enumerable. You can pass it a string or symbol and it returns an instance if it finds it, otherwise it returns nil. It also behaves like Ruby's find where you can pass it a block and it returns the first item that resolves to true.

Priority.find(:high) # => Priority::High.new
Priority.find('high') # => Priority::High.new
Priority.find {|e| e.to_sym == :high } # => Priority::High.new

from classy_enum.